Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965036AbcJVRcu (ORCPT ); Sat, 22 Oct 2016 13:32:50 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:33945 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964798AbcJVRct (ORCPT ); Sat, 22 Oct 2016 13:32:49 -0400 MIME-Version: 1.0 In-Reply-To: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> References: <1477129318-29677-1-git-send-email-baoyou.xie@linaro.org> From: Karol Herbst Date: Sat, 22 Oct 2016 19:32:47 +0200 Message-ID: Subject: Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies To: Baoyou Xie Cc: Ben Skeggs , David Airlie , Alexandre Courbot , Ilia Mirkin , Julia.Lawall@lip6.fr, Martin Peres , rspliet@eclipso.eu, Karol Herbst , arnd@arndb.de, ML nouveau , tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, han.fei@zte.com.cn Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 37 I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie : > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes] > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/nouveau/include/nvkm/core/firmware.h. > So this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > index 34ecd4a..058ff46 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c > @@ -20,6 +20,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > #include > +#include > > /** > * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory > -- > 2.7.4 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau