Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938642AbcJWACa (ORCPT ); Sat, 22 Oct 2016 20:02:30 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:60947 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S935093AbcJWAC3 (ORCPT ); Sat, 22 Oct 2016 20:02:29 -0400 From: "Rafael J. Wysocki" To: Borislav Petkov Cc: Punit Agrawal , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, tbaicar@codeaurora.org, Len Brown Subject: Re: [PATCH] acpi/apei: Fix in-correct return value Date: Sun, 23 Oct 2016 02:09:28 +0200 Message-ID: <2947283.b7DfXarnOp@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.8.0-rc2+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20161022163735.emhpdrzfbyys7rcp@pd.tnic> References: <20161018160719.31252-1-punit.agrawal@arm.com> <1979931.ATDSke4qB1@vostro.rjw.lan> <20161022163735.emhpdrzfbyys7rcp@pd.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 22 On Saturday, October 22, 2016 06:37:35 PM Borislav Petkov wrote: > On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote: > > Boris, all fine here? > > Short answer: Yeah, looks ok to me. > > Longer answer: I mean, this way ghes_proc() *actually* propagates the > return value of ghes_read_estatus() and we don't do any processing if it > failed. > > Which doesn't really tell me a whole lot about the actual processing, > i.e., what ghes_do_proc() did. > > But ghes_do_proc() doesn't return anything and ghes_proc()'s retval is > used only in contexts where we're asking whether something got processed > or not. > > And for that, that fix is adequate. So: > > Reviewed-by: Borislav Petkov Thanks!