Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756271AbcJWBvT (ORCPT ); Sat, 22 Oct 2016 21:51:19 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43106 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbcJWBvQ (ORCPT ); Sat, 22 Oct 2016 21:51:16 -0400 Date: Sat, 22 Oct 2016 20:51:08 -0500 From: Reza Arbab To: Alistair Popple , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Andrew Morton , Stewart Smith , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Chen , linux-mm@kvack.org, "Aneesh Kumar K.V" , Bharata B Rao , Nathan Fontenot Subject: Re: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes References: <1475778995-1420-1-git-send-email-arbab@linux.vnet.ibm.com> <1475778995-1420-3-git-send-email-arbab@linux.vnet.ibm.com> <2344394.NlaWgtFOqB@new-mexico> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2344394.NlaWgtFOqB@new-mexico> Organization: IBM Linux Technology Center User-Agent: Mutt/1.6.2-neo (2016-08-21) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102301-0044-0000-0000-000001883680 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005961; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000187; SDB=6.00771470; UDB=6.00370113; IPR=6.00548186; BA=6.00004823; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013078; XFM=3.00000011; UTC=2016-10-23 01:51:14 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102301-0045-0000-0000-000005B53C13 Message-Id: <20161023015107.527l4fvnh2nrup5u@arbab-vm> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-22_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610230030 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 27 Hi Alistair, On Fri, Oct 21, 2016 at 05:22:54PM +1100, Alistair Popple wrote: >From what I can tell it seems that kernels without this patch will try >and use this memory even if it is marked in the device-tree as >status="disabled" which could lead to problems for older kernels when >we start exporting this property from firmware. > >Arguably this might not be such a problem in practice as we probably >don't have many (if any) existing kernels that will boot on hardware >exporting these properties. Yes, I think you've got it right. >However given this patch seems fairly independent perhaps it is worth >sending as a separate fix if it is not going to make it into this >release? Michael, If this set as a whole is going to miss the release, would it be helpful for me to resend 1/5 and 2/5 as a separate set? They are the minimum needed to prevent the possible forward compatibility issue Alistair describes. -- Reza Arbab