Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938528AbcJWHSB (ORCPT ); Sun, 23 Oct 2016 03:18:01 -0400 Received: from narfation.org ([79.140.41.39]:37607 "EHLO v3-1039.vlinux.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcJWHR7 (ORCPT ); Sun, 23 Oct 2016 03:17:59 -0400 Authentication-Results: v3-1039.vlinux.de; dmarc=none header.from=narfation.org From: Sven Eckelmann To: Jarod Wilson Cc: netdev@vger.kernel.org, davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Date: Sun, 23 Oct 2016 09:17:50 +0200 Message-ID: <2358358.cV5hCSMD7y@sven-edge> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <20161023010826.GD32569@redhat.com> References: <20161022074624.30033-1-sven@narfation.org> <20161023010826.GD32569@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2805415.6Z7vPSiFGp"; micalg="pgp-sha512"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1828 Lines: 47 --nextPart2805415.6Z7vPSiFGp Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: [...] > You're going to > need more than just this revert though, since batman-adv calls > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > batadv_hardif_min_mtu() always returns something 1500 or less. It does only returns 1500 or less at the moment. return min_t(int, min_mtu - batadv_max_header_len(), ETH_DATA_LEN); > Actually, > looking at that, you could omit the mtu < 68 bit from > batadv_interface_change_mtu() too, since that'll already get done in the > core, but I have no clue what you need for max_mtu. I would like to get this revert through net-next.git before anything else. Kind regards, Sven --nextPart2805415.6Z7vPSiFGp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIcBAABCgAGBQJYDGQeAAoJEF2HCgfBJntGuVIQAIzsbzEegMhBUWxVyUQSaa/9 2hrcGTEvAZIkpONvw0b88RAO2OYKRvpI8SgPHCZ49DoGrorE1+Gt9vfSApIWaxrD OMydAEtHzDjAGIxIu5ht2/vS4TzCWhun6lUzZDP+qGCSw1GDRcDQ1VSwhhj2D+TL pwPRF655f78nWQAsO5sXBHakOHzdg+Vqvem1Mpn9Q6or7Svzurtxqm4ZglHpyLTZ uRcpcl9FjFlGkyBn3LSXxhDBoU/UcwlYCFt5hDy616eFJVMsmVaVU3QXQqM/PbTa jCoEjzYyIRE1XAplf86pe+B2QZiIg1/zRs7uCISNTDZ9eRh3yO2bjOuHOjhE/8Br whEXr4ZZbLvO8OgtJaKMqRcx6BRx9tYXGork2vg3ILUfdOa8ivQEFVVZpW2ZObaq LV0f8SmbPtI90pcKM2EH34Z3XhGM4xEBBK3VN/n2Z6ZjOKZaZoearaW+Bm7m9DyO owpAcgMI/oxkaJPVkBMkBwe5QIGFRJKn3TWeSVYRIUU2gdHBlXwZMWbypaNqsQ/I diWyp+c6yiyKqIUOIssiGA9WQeJPzaXnn0Q6pLJWmKxadW4yHmyAoKUKJVhD0+6K Iz40mBAizFdGB7UhF582veriMzsNtWNWFRjHzknbCx+FuF5AO0TXIivjryxVTHKG i+yjQyWLdO8iKiKAP9zb =kdmv -----END PGP SIGNATURE----- --nextPart2805415.6Z7vPSiFGp--