Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753312AbcJWHzf (ORCPT <rfc822;w@1wt.eu>);
        Sun, 23 Oct 2016 03:55:35 -0400
Received: from mail.skyhub.de ([78.46.96.112]:51120 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751428AbcJWHzd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 23 Oct 2016 03:55:33 -0400
Date: Sun, 23 Oct 2016 09:55:29 +0200
From: Borislav Petkov <bp@alien8.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/entry64: remove unused audit related macros
Message-ID: <20161023075528.qrebhx5lmqrulz6t@pd.tnic>
References: <20161022181032.19135-1-kuleshovmail@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20161022181032.19135-1-kuleshovmail@gmail.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 687
Lines: 22

On Sun, Oct 23, 2016 at 12:10:32AM +0600, Alexander Kuleshov wrote:
> which are ocured in the 86a1c34a929f commit (x86_64 syscall audit
> fast-path by Roland McGrath <roland@redhat.com>) and now they are
> not used anymore.

I'd prefer it if you said which patch *removed* them and made those
defines unused again.

What would be even better is if your commit message explained *why* they
were removed in that patch and that because of <insert reason here> we
don't need them here anymore.

This should give people looking at your patch the warm and fuzzy feeling
they need in order to apply it. :-)

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.