From: Sriram Dash <sriram.dash@nxp.com>
To: Alan Stern <stern@rowland.harvard.edu>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "mathias.nyman@intel.com" <mathias.nyman@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Suresh Gupta <suresh.gupta@nxp.com>,
        "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
        Rajat Srivastava <rajat.srivastava@nxp.com>,
        Rajesh Bhagat <rajesh.bhagat@nxp.com>
Subject: RE: [PATCH] usb: xhci: Workaround for erratum-A010129
Thread-Topic: [PATCH] usb: xhci: Workaround for erratum-A010129
Thread-Index: AQHSK6UYpUemb/FvGE2V+bFF2XbHDaCzHXoAgAJ6VjA=
Date: Sun, 23 Oct 2016 06:47:41 +0000
Message-ID: <DB5PR0401MB1925976A0AE62166FCEA633DF5D60@DB5PR0401MB1925.eurprd04.prod.outlook.com>
References: <1477059109-3938-1-git-send-email-sriram.dash@nxp.com>
 <Pine.LNX.4.44L0.1610211243080.1898-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1610211243080.1898-100000@iolanthe.rowland.org>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2016 06:47:41.9768
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1352
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9NBKK6C009891
Content-Length: 2193
Lines: 61

>From: Alan Stern [mailto:stern@rowland.harvard.edu]
>On Fri, 21 Oct 2016, Sriram Dash wrote:
>
>> For the USB3.0 controller, USB 2.0 reset not driven while port is in
>> Resume state. So, do not program the USB 2.0 reset
>> (PORTSC[PR]=1) while in Resume state.
>>
>> Signed-off-by: Rajat Srivastava <rajat.srivastava@nxp.com>
>> Signed-off-by: Sriram Dash <sriram.dash@nxp.com>
>> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
>> ---
>>  drivers/usb/host/xhci-hub.c | 28 +++++++++++++++++++++++++++-
>>  drivers/usb/host/xhci.h     |  1 +
>>  2 files changed, 28 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
>> index 730b9fd..3def0dd 100644
>> --- a/drivers/usb/host/xhci-hub.c
>> +++ b/drivers/usb/host/xhci-hub.c
>> @@ -878,7 +878,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq,
>u16 wValue,
>>  	struct xhci_hcd	*xhci = hcd_to_xhci(hcd);
>>  	int max_ports;
>>  	unsigned long flags;
>> -	u32 temp, status;
>> +	u32 temp, status, tmp_status = 0;
>>  	int retval = 0;
>>  	__le32 __iomem **port_array;
>>  	int slot_id;
>> @@ -1098,6 +1098,32 @@ int xhci_hub_control(struct usb_hcd *hcd, u16
>typeReq, u16 wValue,
>>  			spin_lock_irqsave(&xhci->lock, flags);
>>  			break;
>>  		case USB_PORT_FEAT_RESET:
>> +			/*
>> +			 * Erratum : A010129
>> +			 * Synopsys STAR 9000962562.
>> +			 * USB 2.0 Reset Not Driven While Port in Resume
>> +			 * While in USB 2.0 resume state (the PORTSC.PLS
>> +			 * register bit is set to 4'd15), if the xHCI driver
>> +			 * programs the PORTSC.PR register bit to 1, the
>> +			 * controller does not drive a USB 2.0 reset
>> +			 * and it does not generate a PORTSC.PRC=1 interrupt.
>> +			 * So, The xHCI driver should not program a USB
>> +			 * 2.0 reset (PORTSC.PR=1) while in resume
>> +			 * (PORTSC.PLS=4'd15).
>> +			 */
>> +			if (xhci->quirks & XHCI_PORT_RST_ON_RESUME) {
>
>It's always a bad idea to drive a reset signal while a port is resuming.  We don't
>need a quirk flag for this.  

Hi Alan,

Ok. Then I will make it generic for xhci in the next version.

>The HCD should never do it, and the USB core should
>never tell the HCD to do it.
>
>Alan Stern