Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbcJWMHr (ORCPT ); Sun, 23 Oct 2016 08:07:47 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:34403 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754033AbcJWMHo (ORCPT ); Sun, 23 Oct 2016 08:07:44 -0400 MIME-Version: 1.0 In-Reply-To: <20161021234611.1f737144@bbrezillon> References: <1433786918-21500-2-git-send-email-punnaia@xilinx.com> <20161021203322.GA28655@obsidianresearch.com> <20161021234611.1f737144@bbrezillon> From: punnaiah choudary kalluri Date: Sun, 23 Oct 2016 17:37:42 +0530 X-Google-Sender-Auth: 4B-M18xGmuwns9OB1NtdKvPYlOU Message-ID: Subject: Re: [v7, 1/3] nand: pl353: Add basic driver for arm pl353 smc nand interface To: Boris Brezillon Cc: Jason Gunthorpe , Punnaiah Choudary Kalluri , "mark.rutland@arm.com" , "jussi.kivilinna@iki.fi" , "linux-doc@vger.kernel.org" , "artem.bityutskiy@linux.intel.com" , "linux-mtd@lists.infradead.org" , "arnd@arndb.de" , "michal.simek@xilinx.com" , "ezequiel.garcia@free-electrons.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "jason@lakedaemon.net" , "pawel.moll@arm.com" , "ijc+devicetree@hellion.org.uk" , "joern@logfs.org" , "kpc528@gmail.com" , "robh+dt@kernel.org" , "acourbot@nvidia.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "rob@landley.net" , "galak@codeaurora.org" , "Khoronzhuk, Ivan" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2420 Lines: 63 Hi Boris and Jason, I am doing rework on these patches to accommodate recent changes with respect to ooblayout. Also some of the comments that i have received from Boris as part of the arasan nand controller upstream patches will apply to this driver. So, i will be releasing the next set of patches for this driver soon and request your time for reviewing those patches. for now, please ignore these patches. Regards, Punnaiah On Sat, Oct 22, 2016 at 3:16 AM, Boris Brezillon wrote: > On Fri, 21 Oct 2016 14:33:22 -0600 > Jason Gunthorpe wrote: > >> On Mon, Jun 08, 2015 at 11:38:36PM +0530, Punnaiah Choudary Kalluri wrote: >> > Add driver for arm pl353 static memory controller nand interface with >> > HW ECC support. This controller is used in xilinx zynq soc for interfacing >> > the nand flash memory. >> > >> > Signed-off-by: Punnaiah Choudary Kalluri >> > Changes in v7: >> > - Currently not implemented the memclk rate adjustments. I will >> > look into this later and once the basic driver is accepted. >> > - Fixed GPL licence ident >> > Changes in v6: >> > - Fixed the checkpatch.pl reported warnings >> > - Using the address cycles information from the onfi param page >> > earlier it is hardcoded to 5 in driver >> > Changes in v5: >> > - Configure the nand timing parameters as per the onfi spec >> > Changes in v4: >> > - Updated the driver to sync with pl353_smc driver APIs >> > Changes in v3: >> > - implemented the proper error codes >> > - further breakdown this patch to multiple sets >> > - added the controller and driver details to Documentation section >> > - updated the licenece to GPLv2 >> > - reorganized the pl353_nand_ecc_init function >> > Changes in v2: >> > - use "depends on" rather than "select" option in kconfig >> > - remove unused variable parts >> > - remove dummy helper and use writel_relaxed directly >> >> What is the status of getting this driver merged? I am interested in >> this driver and can provide some help if there are still TODO items. > > I'll try to review it next week. > >> >> At the very least I will test it, is there something newer than v7 out >> there? >> >> Regards, >> Jason >> >> ______________________________________________________ >> Linux MTD discussion mailing list >> http://lists.infradead.org/mailman/listinfo/linux-mtd/ >