Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936498AbcJWMJA (ORCPT ); Sun, 23 Oct 2016 08:09:00 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33072 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933504AbcJWMI5 (ORCPT ); Sun, 23 Oct 2016 08:08:57 -0400 MIME-Version: 1.0 In-Reply-To: <1475828757-926-2-git-send-email-clabbe.montjoie@gmail.com> References: <1475828757-926-1-git-send-email-clabbe.montjoie@gmail.com> <1475828757-926-2-git-send-email-clabbe.montjoie@gmail.com> From: Rami Rosen Date: Sun, 23 Oct 2016 15:08:56 +0300 Message-ID: Subject: Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver To: Corentin Labbe Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, David Miller , Florian Fainelli , andrew@lunn.ch, Netdev , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 36 Hi Corentin, Trivial comment: rx_saf_fai and rx_daf_fail are not used. This implies that also rx_saf_error and rx_daf_error should be removed: > +static const char const estats_str[][ETH_GSTRING_LEN] = { ... > + "rx_header_error", > + "rx_overflow_error", > + "rx_saf_error", > + "rx_daf_error", > + "rx_buf_error", ... > + > +struct sun8i_emac_stats { > + u64 rx_payload_error; ... > + u64 rx_overflow_error; > + u64 rx_saf_fail; > + u64 rx_daf_fail; > + u64 tx_used_desc; > + u64 napi_schedule; > + u64 napi_underflow; > +}; > + Trivial: typo, should be: can transfer > +/* The datasheet said that each descriptor can transfers up to 4096bytes > + * But latter, a register documentation reduce that value to 2048 Regards, Rami Rosen