Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936498AbcJWNdT (ORCPT ); Sun, 23 Oct 2016 09:33:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46072 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbcJWNdQ (ORCPT ); Sun, 23 Oct 2016 09:33:16 -0400 Date: Sun, 23 Oct 2016 15:33:10 +0200 From: Borislav Petkov To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Paolo Bonzini , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/entry64: remove unused audit related macros Message-ID: <20161023133310.hq24zte6n3qqe4f4@pd.tnic> References: <20161023131436.2823-1-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161023131436.2823-1-kuleshovmail@gmail.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1763 Lines: 59 On Sun, Oct 23, 2016 at 07:14:36PM +0600, Alexander Kuleshov wrote: > These macro ocured in the 86a1c34a929f commit (x86_64 syscall audit > fast-path by Roland McGrath ). > > These defines were used in two-phase sycalls entry tracing, but > this functionality was moved to the syscall_trace_enter() from > arch/x86/entry/common.c in the 1f484aa69 commit (x86/entry: Move > C entry and exit code to arch/x86/entry/common.c by Andy Lutomirski > ). > > The syscall_trace_enter() now uses same defines from , > so these defines are no longer used anywhere in entry_64.S and we may > remove them. Good, it is getting there. Very close to what I had in mind, thanks! Now, I went and made it a bit more readable and put the commit IDs and their names on separate lines, like we do in tip: "These macros were added in commit 86a1c34a929f ("x86_64 syscall audit fast-path"). They were used for sycalls auditing, but this functionality was moved to the arch/x86/entry/common.c:syscall_trace_enter() in 1f484aa69046 ("x86/entry: Move C entry and exit code to arch/x86/entry/common.c") syscall_trace_enter() now uses the same defines from , so these defines are no longer used anywhere in entry_64.S and we may remove them." Also, we abbreviate git commits to 12 chars. What you could do is add this to your .gitconfig: [alias] one = show -s --pretty='format:%h (\"%s\")' and then simply do $ git one 1f484aa69 and it'll format it properly for ya. Anyway, just a couple of things to pay attention to in the future. With this, you can add Reviewed-by: Borislav Petkov to your v3. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.