Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756844AbcJWWXy (ORCPT ); Sun, 23 Oct 2016 18:23:54 -0400 Received: from mail-qt0-f179.google.com ([209.85.216.179]:36292 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868AbcJWWXt (ORCPT ); Sun, 23 Oct 2016 18:23:49 -0400 MIME-Version: 1.0 In-Reply-To: <1476823442-31104-1-git-send-email-javier@osg.samsung.com> References: <1476823442-31104-1-git-send-email-javier@osg.samsung.com> From: Linus Walleij Date: Mon, 24 Oct 2016 00:23:48 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpio: ath79: Fix module autoload To: Javier Martinez Canillas Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Alban Bedel , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 817 Lines: 28 On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > $ > > After this patch: > > $ modinfo drivers/gpio/gpio-ath79.ko | grep alias > alias: of:N*T*Cqca,ar9340-gpioC* > alias: of:N*T*Cqca,ar9340-gpio > alias: of:N*T*Cqca,ar7100-gpioC* > alias: of:N*T*Cqca,ar7100-gpio > > Signed-off-by: Javier Martinez Canillas Patch applied with Alban's ACK. Yours, Linus Walleij