Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933070AbcJXCrO (ORCPT ); Sun, 23 Oct 2016 22:47:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:56320 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125AbcJXCrK (ORCPT ); Sun, 23 Oct 2016 22:47:10 -0400 Date: Mon, 24 Oct 2016 10:46:54 +0800 From: xinhui User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "rkrcmar@redhat.com" , David Laight CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "virtualization@lists.linux-foundation.org" , "linux-s390@vger.kernel.org" , "xen-devel-request@lists.xenproject.org" , "kvm@vger.kernel.org" , "kernellwp@gmail.com" , "jgross@suse.com" , "peterz@infradead.org" , "will.deacon@arm.com" , "borntraeger@de.ibm.com" , "mingo@redhat.com" , "paulus@samba.org" , "pbonzini@redhat.com" , "paulmck@linux.vnet.ibm.com" , "boqun.feng@gmail.com" Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check References: <1476998874-2089-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <1476998874-2089-10-git-send-email-xinhui.pan@linux.vnet.ibm.com> <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com> <20161021183951.GA29131@potion> In-Reply-To: <20161021183951.GA29131@potion> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102402-0048-0000-0000-000001CD340C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102402-0049-0000-0000-000046CDD2E6 Message-Id: <580D761E.5000508@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-23_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610240047 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 45 On 2016年10月22日 02:39, rkrcmar@redhat.com wrote: > 2016-10-21 11:27+0000, David Laight: >> From: Pan Xinhui >>> Sent: 20 October 2016 22:28 >>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>> running or not. >>> >>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>> preempted. Other values means the vcpu has been preempted. >>> >>> Signed-off-by: Pan Xinhui >>> --- >>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>> index 2a71c8f..3376f13 100644 >>> --- a/Documentation/virtual/kvm/msr.txt >>> +++ b/Documentation/virtual/kvm/msr.txt >>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>> __u64 steal; >>> __u32 version; >>> __u32 flags; >>> - __u32 pad[12]; >>> + __u8 preempted; >>> + __u32 pad[11]; >>> } >> >> I think I'd be explicit about the 3 pad bytes you've left. > > Seconded. > > With that change are all KVM bits > like below? __u8 preempted; __u8 kvm_pad[3]; > Acked-by: Radim Krčmář > thanks!