Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757185AbcJXEqd (ORCPT ); Mon, 24 Oct 2016 00:46:33 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:36305 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbcJXEq2 (ORCPT ); Mon, 24 Oct 2016 00:46:28 -0400 MIME-Version: 1.0 In-Reply-To: <1477283492-26657-2-git-send-email-okaya@codeaurora.org> References: <1477283492-26657-1-git-send-email-okaya@codeaurora.org> <1477283492-26657-2-git-send-email-okaya@codeaurora.org> From: Jonathan Liu Date: Mon, 24 Oct 2016 15:46:27 +1100 Message-ID: Subject: Re: [PATCH V5 1/3] ACPI, PCI, IRQ: assign ISA IRQ directly during early boot stages To: Sinan Kaya Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net, Bjorn Helgaas , ravikanth.nalla@hpe.com, linux@rainbow-software.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, alex.williamson@redhat.com, linux-pci@vger.kernel.org, Andy Gross , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wim@djo.tudelft.nl, Len Brown , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2209 Lines: 51 On 24 October 2016 at 15:31, Sinan Kaya wrote: > We do not want to store the SCI penalty in the acpi_isa_irq_penalty[] > table because acpi_isa_irq_penalty[] only holds ISA IRQ penalties and > there's no guarantee that the SCI is an ISA IRQ. We add in the SCI > penalty as a special case in acpi_irq_get_penalty(). > > But if we called acpi_penalize_isa_irq() or acpi_irq_penalty_update() > for an SCI that happened to be an ISA IRQ, they stored the SCI > penalty (part of the acpi_irq_get_penalty() return value) in > acpi_isa_irq_penalty[]. Subsequent calls to acpi_irq_get_penalty() > returned a penalty that included *two* SCI penalties. > > Signed-off-by: Sinan Kaya > Acked-by: Bjorn Helgaas > --- > drivers/acpi/pci_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index c983bf7..6229b02 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -849,7 +849,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > continue; > > if (used) > - new_penalty = acpi_irq_get_penalty(irq) + > + new_penalty = acpi_isa_irq_penalty[irq] + > PIRQ_PENALTY_ISA_USED; > else > new_penalty = 0; > @@ -871,7 +871,7 @@ static int __init acpi_irq_penalty_update(char *str, int used) > void acpi_penalize_isa_irq(int irq, int active) > { > if ((irq >= 0) && (irq < ARRAY_SIZE(acpi_isa_irq_penalty))) > - acpi_isa_irq_penalty[irq] = acpi_irq_get_penalty(irq) + > + acpi_isa_irq_penalty[irq] += > (active ? PIRQ_PENALTY_ISA_USED : PIRQ_PENALTY_PCI_USING); > } > > -- > 1.9.1 > This series fixes one or more network adapters not working in Linux 32-bit x86 guest running inside VirtualBox if I have 4 network adapters enabled. The following message no longer appears in the kernel log: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off Tested-by: Jonathan Liu