Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934106AbcJXHf2 (ORCPT ); Mon, 24 Oct 2016 03:35:28 -0400 Received: from s159.web-hosting.com ([68.65.120.118]:59554 "EHLO s159.web-hosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933444AbcJXHf0 (ORCPT ); Mon, 24 Oct 2016 03:35:26 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Jagan Teki Date: Mon, 24 Oct 2016 13:05:20 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/9] mtd: spi-nor: improve macronix_quad_enable() To: Cyrille Pitchen Cc: Brian Norris , "linux-mtd@lists.infradead.org" , nicolas.ferre@atmel.com, boris.brezillon@free-electrons.com, Marek Vasut , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server159.web-hosting.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - openedev.com X-Get-Message-Sender-Via: server159.web-hosting.com: authenticated_id: jagan@openedev.com X-Authenticated-Sender: server159.web-hosting.com: jagan@openedev.com X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 40 On Wed, Oct 5, 2016 at 5:30 PM, Cyrille Pitchen wrote: > The patch checks whether the Quad Enable bit is already set in the Status > Register. If so, the function exits immediately with a successful return > code. Otherwise, a message is now printed telling we're setting the > non-volatile bit. > > Signed-off-by: Cyrille Pitchen Reviewed-by: Jagan Teki > --- > drivers/mtd/spi-nor/spi-nor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index d0fc165d7d66..5c87b2d99507 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1211,6 +1211,11 @@ static int macronix_quad_enable(struct spi_nor *nor) > val = read_sr(nor); > if (val < 0) > return val; > + if (val & SR_QUAD_EN_MX) > + return 0; > + > + /* Update the Quad Enable bit. */ > + dev_info(nor->dev, "setting Macronix Quad Enable (non-volatile) bit\n"); > write_enable(nor); > > write_sr(nor, val | SR_QUAD_EN_MX); Safe to save ret and check the same as well. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India.