Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938625AbcJXJF5 (ORCPT ); Mon, 24 Oct 2016 05:05:57 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:33262 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934778AbcJXJFz (ORCPT ); Mon, 24 Oct 2016 05:05:55 -0400 Date: Mon, 24 Oct 2016 07:05:42 -0200 From: Mauro Carvalho Chehab To: Tiffany Lin Cc: Hans Verkuil , , "Rob Herring" , Matthias Brugger , Daniel Kurtz , Pawel Osciak , Eddie Huang , Yingjoe Chen , , , , , , Subject: Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Message-ID: <20161024070542.65e11e37@vento.lan> In-Reply-To: <1477279328.10501.10.camel@mtksdaap41> References: <1472818800-22558-1-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-2-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-3-git-send-email-tiffany.lin@mediatek.com> <1472818800-22558-4-git-send-email-tiffany.lin@mediatek.com> <20161021110104.5733240e@vento.lan> <1477279328.10501.10.camel@mtksdaap41> Organization: Samsung X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2364 Lines: 75 Em Mon, 24 Oct 2016 11:22:08 +0800 Tiffany Lin escreveu: > Hi Mauro, > > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 2 Sep 2016 20:19:54 +0800 > > Tiffany Lin escreveu: > > > > > Add v4l2 layer decoder driver for MT8173 > > > > > > Signed-off-by: Tiffany Lin > > > > > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc) > > > +{ > > > + int ret = 0; > > > + > > > + switch (fourcc) { > > > + case V4L2_PIX_FMT_H264: > > > + case V4L2_PIX_FMT_VP8: > > > + default: > > > + return -EINVAL; > > > + } > > > > Did you ever test this driver? The above code will *always* return > > -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail! > > > > I suspect that what you wanted to do, instead, is: > > > > switch (fourcc) { > > case V4L2_PIX_FMT_H264: > > case V4L2_PIX_FMT_VP8: > > break; > > default: > > return -EINVAL; > > > > The original idea here is that vp8 and h264 are added in later patches. > If get this patch without later patches, it should return -EINVAL. I noticed your idea, but next time, don't add dead code like that. Reviewers check patch by patch at the order they're present at the patch series. So, don't add something broken by purpose, assuming that it would be fixed later. > > > > Btw, this patch series has also several issues that were pointed by > > checkpatch. Please *always* run checkpatch when submitting your work. > > > > You should take a look at the Kernel documentation about how to > > submit patches, at: > > https://mchehab.fedorapeople.org/kernel_docs/process/index.html > > > > PS.: this time, I fixed the checkpatch issues for you. So, let me know > > if the patch below is OK, and I'll merge it at media upstream, > > assuming that the other patches in this series are ok. > > > > I did run checkpatch, but I don't know why these issues missed. > probably I run checkpatch for all files not for patches. > I will take a look at the documentation and keep this in mind for future > upstream. > Appreciated for your help. Checkpatch should be run patch by patch, as we expect that all patches will follow the coding style and will compile fine, without introducing warnings. I do compile the Kernel for every single patch I merge. Regards, Mauro