MIME-Version: 1.0
In-Reply-To: <1477298581-31291-1-git-send-email-bgolaszewski@baylibre.com>
References: <1477298581-31291-1-git-send-email-bgolaszewski@baylibre.com>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date: Mon, 24 Oct 2016 11:14:17 +0200
Message-ID: <CAMpxmJV_NfxCmT=yR3Mk5BvGOdPOXVHhFsRwzPU=itqDms8cnQ@mail.gmail.com>
Subject: Re: [PATCH v2] drm: tilcdc: implement palette loading for rev1
To: Jyri Sarha <jsarha@ti.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>,
        David Airlie <airlied@linux.ie>, Kevin Hilman <khilman@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Sekhar Nori <nsekhar@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        linux-drm <dri-devel@lists.freedesktop.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 663
Lines: 21

2016-10-24 10:43 GMT+02:00 Bartosz Golaszewski <bgolaszewski@baylibre.com>:
> Revision 1 of the IP doesn't work if we don't load the palette (even
> if it's not used, which is the case for the RGB565 format).
>
> Add a function called from tilcdc_crtc_enable() which performs all
> required actions if we're dealing with a rev1 chip.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> v1 -> v2:
> - only allocate dma memory for revision 1
>

Superseded by v3.

Sorry for the noise, but I only noticed that a resource managed
version of dma_alloc_coherent() exists after having sent out v2. This
simplifies the code a bit.

Thanks,
Bartosz