Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938719AbcJXJgM (ORCPT ); Mon, 24 Oct 2016 05:36:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41216 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938647AbcJXJgJ (ORCPT ); Mon, 24 Oct 2016 05:36:09 -0400 Date: Mon, 24 Oct 2016 12:35:31 +0300 From: Dan Carpenter To: Jonathan Cameron Cc: Brian Masney , devel@driverdev.osuosl.org, lars@metafoo.de, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de Subject: Re: [PATCH 6/7] iio: light: tsl2583: add locking to sysfs *_store() functions Message-ID: <20161024093530.GV4469@mwanda> References: <1476873130-24926-1-git-send-email-masneyb@onstation.org> <1476873130-24926-6-git-send-email-masneyb@onstation.org> <20161019113345.GJ4469@mwanda> <20161019113731.GF4418@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 582 Lines: 21 On Sat, Oct 22, 2016 at 06:29:55PM +0100, Jonathan Cameron wrote: > On 19/10/16 12:37, Dan Carpenter wrote: > > I appologize for laughing, but I am still secretly amused in my heart. > > > > regards, > > dan carpenter > > > Fewer beers or less caffeine for Dan! ;) > > Key take away here is keep things simple. The gotos in my mind > would actually have made sense, but I wouldn't do the refactoring until > you need it. i.e. when you introduce the locking in this patch. Yeah, I totally agree do it when you need it. I like gotos if they're needed. regards, dan carpenter