Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938756AbcJXJko (ORCPT ); Mon, 24 Oct 2016 05:40:44 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58126 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936089AbcJXJkm (ORCPT ); Mon, 24 Oct 2016 05:40:42 -0400 X-ME-Sender: X-Sasl-enc: 073pXVoW+whjKnwGOm+mNUObWP7RGz/jk83ND3Jab/TZ 1477302041 Subject: Re: [PATCH net-next 4/5] ipv6: Compute multipath hash for sent ICMP errors from offending packet To: Jakub Sitnicki , netdev@vger.kernel.org References: <1477301332-23954-1-git-send-email-jkbs@redhat.com> <1477301332-23954-5-git-send-email-jkbs@redhat.com> Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Eric Dumazet From: Hannes Frederic Sowa Message-ID: <95fdee03-d595-f1fd-b10d-fc775feaef2b@stressinduktion.org> Date: Mon, 24 Oct 2016 11:40:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477301332-23954-5-git-send-email-jkbs@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 17 On 24.10.2016 11:28, Jakub Sitnicki wrote: > Improve debuggability with tools like traceroute and make PMTUD work in > setups that make use of ECMP routing by sending ICMP errors down the > same path as the offending packet would travel, if it was going in the > opposite direction. > > There is a caveat, flows in both directions need use the same > label. Otherwise packets from flow in the opposite direction and ICMP > errors will not be routed over the same ECMP link. > > Export the function for calculating the multipath hash so that we can > use it also on receive side, when forwarding ICMP errors. > > Signed-off-by: Jakub Sitnicki Acked-by: Hannes Frederic Sowa