Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938737AbcJXJuF (ORCPT ); Mon, 24 Oct 2016 05:50:05 -0400 Received: from foss.arm.com ([217.140.101.70]:47284 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936310AbcJXJuD (ORCPT ); Mon, 24 Oct 2016 05:50:03 -0400 Date: Mon, 24 Oct 2016 10:49:31 +0100 From: Mark Rutland To: Heiko Carstens Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, akpm@linux-foundation.org, hpa@zytor.com, keescook@chromium.org, luto@kernel.org, mingo@redhat.com, tglx@linutronix.de Subject: Re: [PATCH 3/3] thread_info: include for THREAD_INFO_IN_TASK Message-ID: <20161024094931.GB15620@leverpostej> References: <1476901693-8492-1-git-send-email-mark.rutland@arm.com> <1476901693-8492-4-git-send-email-mark.rutland@arm.com> <20161020102925.GA3529@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020102925.GA3529@osiris> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1828 Lines: 48 On Thu, Oct 20, 2016 at 12:29:26PM +0200, Heiko Carstens wrote: > On Wed, Oct 19, 2016 at 07:28:13PM +0100, Mark Rutland wrote: > > When CONFIG_THREAD_INFO_IN_TASK is selected, the current_thread_info() > > macro relies on current having been defined prior to its use. However, > > not all users of current_thread_info() include , and thus > > current is not guaranteed to be defined. > > > > When CONFIG_THREAD_INFO_IN_TASK is not selected, it's possible that > > get_current() / current are based upon current_thread_info(), and > > includes . Thus always including > > would result in circular dependences on some platforms. > > > > To ensure both cases work, this patch includes , but only > > when CONFIG_THREAD_INFO_IN_TASK is selected. > > > > Signed-off-by: Mark Rutland > > Cc: Andrew Morton > > Cc: Andy Lutomirski > > Cc: Heiko Carstens > > Cc: Kees Cook > > --- > > include/linux/thread_info.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > > index c75c6ab..ef1f4b0 100644 > > --- a/include/linux/thread_info.h > > +++ b/include/linux/thread_info.h > > @@ -12,6 +12,7 @@ > > #include > > > > #ifdef CONFIG_THREAD_INFO_IN_TASK > > +#include > > #define current_thread_info() ((struct thread_info *)current) > > #endif > > FWIW: > Acked-by: Heiko Carstens Cheers! Would you be happy to do the same for patch 2? Once these have a couple more acks I'll drop these on a (hopefully) stable branch, tagged so that we can both use them as a base. Thanks, Mark.