Date: Mon, 24 Oct 2016 10:56:13 +0100
From: liviu.dudau@arm.com
To: Brian Starkey <brian.starkey@arm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY
Message-ID: <20161024095613.GM8762@e106497-lin.cambridge.arm.com>
References: <1477302748-22617-1-git-send-email-brian.starkey@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1477302748-22617-1-git-send-email-brian.starkey@arm.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1123
Lines: 39

On Mon, Oct 24, 2016 at 10:52:28AM +0100, Brian Starkey wrote:
> We need to explicitly disable our planes, so don't set the flag which
> would otherwise skip the plane disable when the CRTC is disabled.
> 
> Signed-off-by: Brian Starkey <brian.starkey@arm.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

> ---
>  drivers/gpu/drm/arm/malidp_drv.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 9ed938e..f7bb763 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -102,8 +102,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
>  	 */
>  	malidp_mw_atomic_commit(drm, state);
>  
> -	drm_atomic_helper_commit_planes(drm, state,
> -					DRM_PLANE_COMMIT_ACTIVE_ONLY);
> +	drm_atomic_helper_commit_planes(drm, state, 0);
>  
>  	malidp_atomic_commit_hw_done(state);
>  
> -- 
> 1.7.9.5
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯