Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933770AbcJXKEb (ORCPT ); Mon, 24 Oct 2016 06:04:31 -0400 Received: from mail-vk0-f41.google.com ([209.85.213.41]:33608 "EHLO mail-vk0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753162AbcJXKE3 (ORCPT ); Mon, 24 Oct 2016 06:04:29 -0400 MIME-Version: 1.0 In-Reply-To: <2193537.0Se2hussi4@wuerfel> References: <1476953642-2160-1-git-send-email-binoy.jayan@linaro.org> <1476953642-2160-2-git-send-email-binoy.jayan@linaro.org> <2193537.0Se2hussi4@wuerfel> From: Binoy Jayan Date: Mon, 24 Oct 2016 15:34:27 +0530 Message-ID: Subject: Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , kevin Barnett , Don Brace , Scott Benesh , Johannes Thumshirn , linux-scsi@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 21 Hi Arnd On 20 October 2016 at 14:36, Arnd Bergmann wrote: > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: >> Semaphores are going away in the future, so replace the semaphore >> sync_request_sem with the a mutex lock. timeout_msecs is not used >> for the lock sync_request_sem, so remove the timed locking too. >> >> Signed-off-by: Binoy Jayan > > The patch looks correct to me, but I think if you remove the support > for handling timeouts, you should update the prototype of > pqi_submit_raid_request_synchronous to no longer pass the timeout > argument in the first place. But we still need "timeout_msecs" in a call to pqi_submit_raid_request_synchronous_with_io_request() drivers/scsi/smartpqi/smartpqi_init.c +3484 -Binoy