Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628AbcJXKJd (ORCPT ); Mon, 24 Oct 2016 06:09:33 -0400 Received: from mail-ua0-f172.google.com ([209.85.217.172]:35585 "EHLO mail-ua0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbcJXKJ2 (ORCPT ); Mon, 24 Oct 2016 06:09:28 -0400 MIME-Version: 1.0 In-Reply-To: <3118730.6uvAdDZXCF@wuerfel> References: <1476953642-2160-1-git-send-email-binoy.jayan@linaro.org> <1476953642-2160-2-git-send-email-binoy.jayan@linaro.org> <3118730.6uvAdDZXCF@wuerfel> From: Binoy Jayan Date: Mon, 24 Oct 2016 15:39:27 +0530 Message-ID: Subject: Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , kevin Barnett , Don Brace , Scott Benesh , Johannes Thumshirn , linux-scsi@vger.kernel.org, Linux kernel mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 18 On 20 October 2016 at 14:40, Arnd Bergmann wrote: > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: >> - sema_init(&ctrl_info->sync_request_sem, >> - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS); >> + mutex_init(&ctrl_info->sync_request_mutex); >> > > Looking at this again, I see that PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS > is '3', so this is in fact a counting semaphore rather than a mutex, > and the conversion is changing the behavior. > > The patch can't go in unless you either show that it should be > a normal mutex rather than a counting semaphore, or you find a way > to keep the behavior the same. This still holds true, will try changing this accordingly. -Binoy