Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755768AbcJXKLI (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 06:11:08 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:62364 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751606AbcJXKLH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 06:11:07 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        kevin Barnett <kevin.barnett@microsemi.com>,
        Don Brace <don.brace@microsemi.com>,
        Scott Benesh <scott.benesh@microsemi.com>,
        Johannes Thumshirn <jthumshirn@suse.de>, linux-scsi@vger.kernel.org,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex
Date: Mon, 24 Oct 2016 12:10:49 +0200
Message-ID: <3504862.DmmQhD8X6k@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAHv-k_956e7bFnMedo34nJS=nQ-OC=UUic+VsAYSRL69iTeX+A@mail.gmail.com>
References: <1476953642-2160-1-git-send-email-binoy.jayan@linaro.org> <2193537.0Se2hussi4@wuerfel> <CAHv-k_956e7bFnMedo34nJS=nQ-OC=UUic+VsAYSRL69iTeX+A@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:hgwuQRjEDpuHE3YPc2KHuQWPuf3JDf7nL/EPMnAcVnMlAnuoEyv
 jmm8JyBWl4Ur58MrIsa0jvKjMnctlfECVoO5gfI+Qht9Xz+owi3H+qCfCeZyhYmpNzVid1V
 oBVGdoGsa6Tv74IjamnmP6tHhxgjjmbE2d/FpUWzqnfo8m5YX4wYMYunh+t9q2BcNY8cb6s
 SFyQaJfzNxkitY6W/T5Vg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:kQPTCt/zJ50=:Gk5JQP0dRqNnya8P6vbejI
 uglIn0hYvarmuRVTkSODIx7LRLDZlziIEP7BhFVY1xGotr1WAYXKjSsudSHFAmTMPkjx7uTjy
 rgPnn28C2Ft/wIMkhF6ZPWK5Mxx56QFQ1JuUHpEFGPkgpjEpwZqVfZjloGTgDQYMOxT7SIxx+
 7a4YXpGWwqJhts7Zmc0lc5GxpaQ2sgmEt5MnXjkpzSoS5Z2stDJy7UmIMWnD8mzzO1BA+IGJP
 MV4yRr4zjp2PIOcJl6rQ7fNUFL5+f0n3Ap8etVDaCf0E8PewytJV44UdxLPKVjB1Lbr5IvJSl
 9xcPT3el/9IiM7KMbGdWC6Pjvyc6Vek7N7kLV3np+LCMlrjYpfl4fHUYeGXJabseuC0IS/7Zw
 g7Mkrnyc20/HvghTVddAxPpXxCiluWZohB5YL20oSOvyCpehlrd5c1i3npumdf9JPM4lIrNUY
 bIYLH4L5WbKnBz/mPd3cIjOdfCxPMDU2mCQNchfYOymh5cTWQLXzld6Yktb8XdaGH4OH5ZbRx
 tU7n0S7bnMbpcVTk7QCq7ZuuYk9T3CC8/sSbb36pKZJhHeKFpKLYRyU76OiJjR8vTovGnKwUU
 Uyhqly6rnmH0M/5gDxy/ZdH2izgpf6Il3DbniAT2S/pqVJk52DxfGQpOxg2MmqwQKH4BC2/pp
 +iNQ5W5sxowzYNx6v1kDRbMENKhMSkHUaWvd6Sroe5pXOsYZkbGKZjXPPquFNuGayqmxPzdFx
 6FoZfpGWIJrQWr5W
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 943
Lines: 24

On Monday, October 24, 2016 3:34:27 PM CEST Binoy Jayan wrote:
> Hi Arnd
> 
> On 20 October 2016 at 14:36, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote:
> >> Semaphores are going away in the future, so replace the semaphore
> >> sync_request_sem with the a mutex lock. timeout_msecs is not used
> >> for the lock sync_request_sem, so remove the timed locking too.
> >>
> >> Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
> >
> > The patch looks correct to me, but I think if you remove the support
> > for handling timeouts, you should update the prototype of
> > pqi_submit_raid_request_synchronous to no longer pass the timeout
> > argument in the first place.
> 
> But we still need "timeout_msecs" in a call to
> pqi_submit_raid_request_synchronous_with_io_request()
> 
> drivers/scsi/smartpqi/smartpqi_init.c +3484

Why? If it's always zero, we can remove that too.

	Arnd