Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756895AbcJXKTC (ORCPT ); Mon, 24 Oct 2016 06:19:02 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:54638 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755374AbcJXKS6 (ORCPT ); Mon, 24 Oct 2016 06:18:58 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH] drm/arm: mark symbols static where possible Date: Mon, 24 Oct 2016 12:18:37 +0200 Message-ID: <6967038.koRMV7E4Wg@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1477127581-1095-1-git-send-email-baoyou.xie@linaro.org> References: <1477127581-1095-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GreBjolrUcFQV1BUZIcLYk5bDtA56stb57qMvGHPlse1pFHuXcU 2eiQ6DGoS9SBGVLa4G+/+S06o7FBdkcA7uE/PyoaDkGvHuYmtLcrJrtTywUIYj0TNwehSmb xI0QaOLge9id1YidhHyoKyyoYFBGpCrpv1oIGIyWhQWAfmv1/qJki3lyCqVFvvjm06jBFpq D0Nuh7hCfAgB+BCJzEz7g== X-UI-Out-Filterresults: notjunk:1;V01:K0:wQsHUXM+GXs=:ncnuiz/SIFw2efHRkgKtU6 AcO2rZVGImMLUS3v/ujd/gfQsOLfd3r+OyHNMf8p1pa69pfikWwSolWhJhtCQN7DgfhFdbpbx 4VQBcFlqN3cy6URqrmemCFQYANokcsFl+9kHnjoy7RrKv6JnvIZko23LUjNN6V18e09kcZvND iPQsWsaZxWUbbdfBLT3Uq1k7Crr+0IeeKxF8wR52kqD0EVSoLy8tpeY7s3KfowNBI2SH7vN76 guAX1z5pdSCX7QUV+mGBDa72oieC4izai+vkGzDWQfWdPEIoRoK6PoCaKNvye/nU1Kj7aKhah HgF4om3nSnz713qAVikicF2XpMDr0tCwbLHSvcVfSR7lNHgkpQM+s+F8QS1tV1tfS/L3h9lvS 9gSBYSDHHycGDCyGV39SbWBEBER+Uq6Qc3fRlEjeDO+ClV/cxvSX6NPBM79iJ4IBtILwSFJN1 2iZW8OdnlnVolFCZZgGm5jZ8v4ldhbqJy1NODV131IlGFP5KLdwg6bF5T3wjNyuD1FPd6+ndZ D/0+OiUXT442LUTTnOPpMcc1tGc1kJUZgXVjYwZ8Z0YHpaVHg8nS81+FsBgJiZOIZCnmlOse1 fKqWEzMYuBX6+d2YGlRE5HXY3Q5WQ/gFS7Ta1PB3gF4d6rdVwW0zm734gWHlm3oeZfknJg+kQ KfrxdsqI1r/1ysjp29WdxhIPJQQVTET530UpdvlPsRkoahdV+2w4rRdBngcwl0hW3CIAjLcJe mXagbYSMHQ09ZWJC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 31 On Saturday, October 22, 2016 5:13:01 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for 'malidp_duplicate_plane_state' [-Wmissing-prototypes] > drivers/gpu/drm/arm/malidp_planes.c:66:6: warning: no previous prototype for 'malidp_destroy_plane_state' [-Wmissing-prototypes] > > In fact, both functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- ... > @@ -63,7 +64,7 @@ struct drm_plane_state *malidp_duplicate_plane_state(struct drm_plane *plane) > return &state->base; > } > > -void malidp_destroy_plane_state(struct drm_plane *plane, > +static void malidp_destroy_plane_state(struct drm_plane *plane, > struct drm_plane_state *state) > { > struct malidp_plane_state *m_state = to_malidp_plane_state(state); > The change looks correct, but I notice that the two lines of the declaration are no longer aligned. The file follows the normal style of aligning the argument list in the second line to line up with the opening '(', so please keep it that way. Arnd