Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757298AbcJXKrX (ORCPT ); Mon, 24 Oct 2016 06:47:23 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:52961 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756913AbcJXKrU (ORCPT ); Mon, 24 Oct 2016 06:47:20 -0400 From: Colin King To: Vineet Gupta , Jiri Slaby , Andrew Morton , linux-snps-arc@lists.infradead.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall Date: Mon, 24 Oct 2016 11:47:14 +0100 Message-Id: <20161024104714.10047-1-colin.king@canonical.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 25 From: Colin Ian King arc_usr_cmpxchg currently returns an uninitialized value in ret on a failed access_ok call. Instead, return -EFAULT. Signed-off-by: Colin Ian King --- arch/arc/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c index a746008..9ae3e1c 100644 --- a/arch/arc/kernel/process.c +++ b/arch/arc/kernel/process.c @@ -47,7 +47,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new) int ret; if (!access_ok(VERIFY_WRITE, uaddr, sizeof(int))) - return ret; + return -EFAULT; preempt_disable(); -- 2.9.3