Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757379AbcJXK7n (ORCPT ); Mon, 24 Oct 2016 06:59:43 -0400 Received: from mail-yw0-f178.google.com ([209.85.161.178]:33090 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756129AbcJXK7l (ORCPT ); Mon, 24 Oct 2016 06:59:41 -0400 MIME-Version: 1.0 In-Reply-To: <1477300438-20091-1-git-send-email-bgolaszewski@baylibre.com> References: <1477300438-20091-1-git-send-email-bgolaszewski@baylibre.com> From: Bartosz Golaszewski Date: Mon, 24 Oct 2016 12:59:40 +0200 Message-ID: Subject: Re: [PATCH v3] drm: tilcdc: implement palette loading for rev1 To: Jyri Sarha , Tomi Valkeinen , David Airlie , Kevin Hilman , Michael Turquette , Sekhar Nori Cc: LKML , linux-drm , Laurent Pinchart , Peter Ujfalusi , Bartosz Golaszewski Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 560 Lines: 19 2016-10-24 11:13 GMT+02:00 Bartosz Golaszewski : > Revision 1 of the IP doesn't work if we don't load the palette (even > if it's not used, which is the case for the RGB565 format). > > Add a function called from tilcdc_crtc_enable() which performs all > required actions if we're dealing with a rev1 chip. > > Signed-off-by: Bartosz Golaszewski > --- > v1 -> v2: > - only allocate dma memory for revision 1 > > v2 -> v3: > - use devres managed API for dma memory allocation > Superseded by v4. Bartosz