Message-ID: <1477307377.6666.1.camel@crowfest.net>
Subject: Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in
 vchiq_copy_from_user
From: Michael Zoran <mzoran@crowfest.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        daniels@collabora.com, linux-kernel@vger.kernel.org, eric@anholt.net,
        noralf@tronnes.org, popcornmix@gmail.com
Date: Mon, 24 Oct 2016 04:09:37 -0700
In-Reply-To: <20161024105403.GA4469@mwanda>
References: <20161024052918.28205-1-mzoran@crowfest.net>
         <20161024105403.GA4469@mwanda>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1679
Lines: 51

On Mon, 2016-10-24 at 13:54 +0300, Dan Carpenter wrote:
> On Sun, Oct 23, 2016 at 10:29:18PM -0700, mzoran@crowfest.net wrote:
> > From: Michael Zoran <mzoran@crowfest.net>
> > 
> > Signed-off-by: Michael Zoran <mzoran@crowfest.net>
> > ---
> >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.
> > c
> > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.
> > c
> > index 32d12e6..98c6819 100644
> > ---
> > a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.
> > c
> > +++
> > b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.
> > c
> > @@ -219,7 +219,7 @@ remote_event_signal(REMOTE_EVENT_T *event)
> >  int
> >  vchiq_copy_from_user(void *dst, const void *src, int size)
> >  {
> > -	if ((uint32_t)src < TASK_SIZE) {
> > +	if ((unsigned long)src < TASK_SIZE) {
> >  		return copy_from_user(dst, src, size);
> >  	} else {
> >  		memcpy(dst, src, size);
> 
> 
> This code looks totally wrong still.  That's not how we differentiate
> kernel pointers from user pointers.
> 
> Also no commit message (I tend not to read the subject) so it took me
> a
> while to figure out what was going on.  Anyway, everything needs a
> commit message.  That's a rule.
> 
> regards,
> dan carpenter
> 

I didn't think it looked totally correct, but I'm not sure it's any
more broken then what is already in the tree.

If you can kindly point me to some other source code or documentation
to look at that is correct, I'm more then willing to fix the patch.