Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757419AbcJXLLp (ORCPT ); Mon, 24 Oct 2016 07:11:45 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:35066 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756179AbcJXLLn (ORCPT ); Mon, 24 Oct 2016 07:11:43 -0400 MIME-Version: 1.0 In-Reply-To: <20161024104655.GZ4469@mwanda> References: <20161023210526.GA14124@gmail.com> <20161024104655.GZ4469@mwanda> From: Geert Uytterhoeven Date: Mon, 24 Oct 2016 13:11:41 +0200 X-Google-Sender-Auth: nPVAJBPBzXOVg49FJczim-NLFsg Message-ID: Subject: Re: [PATCH] Staging:board:board: fix implicit declaration of function To: Dan Carpenter Cc: Nadim Almas , Greg KH , driverdevel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9OBBnM6013522 Content-Length: 845 Lines: 24 On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter wrote: > On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote: >> implicit declaration of function ‘of_find_all_nodes’ reported by sparse >> > > No. Include the correct header file instead. drivers/staging/board/board.c already includes , which provides the prototype, but only if CONFIG_OF=y. However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ, which both depend on OF. So how can this happen?? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds