Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331AbcJXLWp (ORCPT ); Mon, 24 Oct 2016 07:22:45 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:33650 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752171AbcJXLWn (ORCPT ); Mon, 24 Oct 2016 07:22:43 -0400 From: Alexander Kuleshov To: Thomas Gleixner Cc: Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Borislav Petkov , Paolo Bonzini , linux-kernel@vger.kernel.org, Alexander Kuleshov Subject: [PATCH] x86/entry64: move comment about informing of context tracking in right place Date: Mon, 24 Oct 2016 17:22:34 +0600 Message-Id: <20161024112234.21898-1-kuleshovmail@gmail.com> X-Mailer: git-send-email 2.8.0.rc3.1353.gea9bdc0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 42 We are switching to kernel gsbase if an IRQ come from usermode with swpags. Now there is comment which describes this: IRQ from user mode. Switch to kernel gsbase and inform context tracking that we're in kernel mode. But now we execute swapgs, next TRACE_IRQS_OFF and only then the CALL_enter_from_user_mode macro expands to the informing of context tracking about this event. Let's move part of comment to the right place where actual call to context tracing occured. Signed-off-by: Alexander Kuleshov --- arch/x86/entry/entry_64.S | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index ef766a3..5e97642 100644 --- a/arch/x86/entry/entry_64.S +++ b/arch/x86/entry/entry_64.S @@ -474,8 +474,7 @@ END(irq_entries_start) jz 1f /* - * IRQ from user mode. Switch to kernel gsbase and inform context - * tracking that we're in kernel mode. + * IRQ from user mode. Switch to kernel gsbase. */ SWAPGS @@ -489,6 +488,9 @@ END(irq_entries_start) */ TRACE_IRQS_OFF + /* + * Inform context tracking that we're in kernel mode. + */ CALL_enter_from_user_mode 1: -- 2.8.0.rc3.1353.gea9bdc0