Date: Mon, 24 Oct 2016 14:36:01 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Zoran <mzoran@crowfest.net>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        daniels@collabora.com, linux-kernel@vger.kernel.org, eric@anholt.net,
        noralf@tronnes.org, popcornmix@gmail.com
Subject: Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in
 vchiq_copy_from_user
Message-ID: <20161024113601.GL4418@mwanda>
References: <20161024052918.28205-1-mzoran@crowfest.net>
 <20161024105403.GA4469@mwanda>
 <1477307377.6666.1.camel@crowfest.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1477307377.6666.1.camel@crowfest.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 669
Lines: 18

On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> I didn't think it looked totally correct, but I'm not sure it's any
> more broken then what is already in the tree.

It's not more broken.  But better to leave the compile warning there to
mark that it is an obvious security problem.

> 
> If you can kindly point me to some other source code or documentation
> to look at that is correct, I'm more then willing to fix the patch.
> 

I was hoping the maintainers could chip in, because I didn't want to
look at the code.  We really need to track which are use pointers and
which are kernel pointers.  We can't mix them like this.

regards,
dan carpenter