Message-ID: <1477309189.6666.6.camel@crowfest.net>
Subject: Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in
 vchiq_copy_from_user
From: Michael Zoran <mzoran@crowfest.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        daniels@collabora.com, linux-kernel@vger.kernel.org, eric@anholt.net,
        noralf@tronnes.org, popcornmix@gmail.com
Date: Mon, 24 Oct 2016 04:39:49 -0700
In-Reply-To: <20161024113601.GL4418@mwanda>
References: <20161024052918.28205-1-mzoran@crowfest.net>
         <20161024105403.GA4469@mwanda> <1477307377.6666.1.camel@crowfest.net>
         <20161024113601.GL4418@mwanda>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 27

On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > I didn't think it looked totally correct, but I'm not sure it's any
> > more broken then what is already in the tree.
> 
> It's not more broken.  But better to leave the compile warning there
> to
> mark that it is an obvious security problem.
> 
> > 
> > If you can kindly point me to some other source code or
> > documentation
> > to look at that is correct, I'm more then willing to fix the patch.
> > 
> 
> I was hoping the maintainers could chip in, because I didn't want to
> look at the code.  We really need to track which are use pointers and
> which are kernel pointers.  We can't mix them like this.
> 
> regards,
> dan carpenter
> 

The problem is that I'm mostly interested in arm64 ATM, and I don't
think the existing code works at all with 64 bit pointers.

Broken as it may be...