Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757466AbcJXObS (ORCPT ); Mon, 24 Oct 2016 10:31:18 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34250 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbcJXObO (ORCPT ); Mon, 24 Oct 2016 10:31:14 -0400 Date: Mon, 24 Oct 2016 16:31:09 +0200 From: Daniel Vetter To: Arnd Bergmann Cc: Baoyou Xie , cstout@chromium.org, linux-arm-msm@vger.kernel.org, tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, han.fei@zte.com.cn, freedreno@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/msm: add missing header dependencies Message-ID: <20161024143109.GR20761@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , Baoyou Xie , cstout@chromium.org, linux-arm-msm@vger.kernel.org, tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, han.fei@zte.com.cn, freedreno@lists.freedesktop.org References: <1477127865-9381-1-git-send-email-baoyou.xie@linaro.org> <1477127865-9381-2-git-send-email-baoyou.xie@linaro.org> <3851598.AOg1ik44fH@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3851598.AOg1ik44fH@wuerfel> X-Operating-System: Linux phenom 4.6.0-1-amd64 User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 31 On Mon, Oct 24, 2016 at 12:13:40PM +0200, Arnd Bergmann wrote: > On Saturday, October 22, 2016 5:17:45 PM CEST Baoyou Xie wrote: > > We get 2 warnings when building kernel with W=1: > > drivers/gpu/drm/msm/msm_debugfs.c:141:5: warning: no previous prototype for 'msm_debugfs_init' [-Wmissing-prototypes] > > drivers/gpu/drm/msm/msm_debugfs.c:158:6: warning: no previous prototype for 'msm_debugfs_cleanup' [-Wmissing-prototypes] > > > > In fact, these functions are declared in > > drivers/gpu/drm/msm/msm_debugfs.h. > > So this patch adds missing header dependencies. > > > > Signed-off-by: Baoyou Xie > > > > Both patches > > Reviewed-by: Arnd Bergmann Both applied to drm-misc, thanks. > Strangely, something caused the second mail to show up as a reply to the > first. No idea how that happened, but you may want to check the procedure > you used for sending the mails. Not generated as a series, but individual patches, but then send out using just 1 invocation of git send-email? "add" sorts before "adreno", and git format-patch changes every non-alphanumeric character to a '-'. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch