Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <20161006080021.GD19785@shodan.usersys.redhat.com>
References: <20161006080021.GD19785@shodan.usersys.redhat.com> <1473179547-12101-1-git-send-email-k.marinushkin@gmail.com> <32083.1473167516@warthog.procyon.org.uk> <25951.1473185773@warthog.procyon.org.uk>
To: Artem Savkov <asavkov@redhat.com>
Cc: dhowells@redhat.com, Kirill Marinushkin <k.marinushkin@gmail.com>,
        paul.gortmaker@windriver.com, james.l.morris@oracle.com,
        keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32687.1477320654.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: 8BIT
Date: Mon, 24 Oct 2016 15:50:54 +0100
Message-ID: <32688.1477320654@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 20

Artem Savkov <asavkov@redhat.com> wrote:

> > > IMO, the preferable fix depends on your future plan.
> > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with the
> > > patch suggested by Artem Savkov.
> > > If you plan to reduce using ANSI X9.31 DRNG and use DRBG more widely - I
> > > suggest my patch.
> > 
> > No such plans, TBH.
> 
> I agre with Kirill here, so if we are not trying to reduce ANSI X9.31
> DRNG usage can we move on with the suggested patch, or are there any
> issues with it that need addressing?

Which suggested patch?  One of Kirill's (there are at least two) or yours?

Note that we *also* need the "KEYS: Sort out big_key initialisation" patch -
just changing the Kconfig is not sufficient a fix in and of itself.

David