Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941121AbcJXPFs (ORCPT ); Mon, 24 Oct 2016 11:05:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933214AbcJXPFq (ORCPT ); Mon, 24 Oct 2016 11:05:46 -0400 Date: Mon, 24 Oct 2016 17:05:39 +0200 From: "rkrcmar@redhat.com" To: Paolo Bonzini Cc: David Laight , "'Pan Xinhui'" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "virtualization@lists.linux-foundation.org" , "linux-s390@vger.kernel.org" , "xen-devel-request@lists.xenproject.org" , "kvm@vger.kernel.org" , "kernellwp@gmail.com" , "jgross@suse.com" , "peterz@infradead.org" , "will.deacon@arm.com" , "borntraeger@de.ibm.com" , "mingo@redhat.com" , "paulus@samba.org" , "paulmck@linux.vnet.ibm.com" , "boqun.feng@gmail.com" Subject: Re: [PATCH v5 9/9] Documentation: virtual: kvm: Support vcpu preempted check Message-ID: <20161024150539.GA3197@potion> References: <1476998874-2089-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> <1476998874-2089-10-git-send-email-xinhui.pan@linux.vnet.ibm.com> <063D6719AE5E284EB5DD2968C1650D6DB0207B44@AcuExch.aculab.com> <20161021183951.GA29131@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 24 Oct 2016 15:05:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 44 2016-10-24 16:42+0200, Paolo Bonzini: > On 21/10/2016 20:39, rkrcmar@redhat.com wrote: >> 2016-10-21 11:27+0000, David Laight: >>> From: Pan Xinhui >>>> Sent: 20 October 2016 22:28 >>>> Commit ("x86, kvm: support vcpu preempted check") add one field "__u8 >>>> preempted" into struct kvm_steal_time. This field tells if one vcpu is >>>> running or not. >>>> >>>> It is zero if 1) some old KVM deos not support this filed. 2) the vcpu is >>>> preempted. Other values means the vcpu has been preempted. >>>> >>>> Signed-off-by: Pan Xinhui >>>> --- >>>> Documentation/virtual/kvm/msr.txt | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt >>>> index 2a71c8f..3376f13 100644 >>>> --- a/Documentation/virtual/kvm/msr.txt >>>> +++ b/Documentation/virtual/kvm/msr.txt >>>> @@ -208,7 +208,8 @@ MSR_KVM_STEAL_TIME: 0x4b564d03 >>>> __u64 steal; >>>> __u32 version; >>>> __u32 flags; >>>> - __u32 pad[12]; >>>> + __u8 preempted; >>>> + __u32 pad[11]; >>>> } >>> >>> I think I'd be explicit about the 3 pad bytes you've left. >> >> Seconded. >> >> With that change are all KVM bits >> >> Acked-by: Radim Krčmář > > Saw this after replying to the previous message. If you need to post v6 > of the full series, it would be nice if you removed the > kvm_read_guest_cached. But anyway it wasn't my intention to override Radim. The patch was acceptable to me even now, so I definitely wouldn't mind if it were even nicer. :)