Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbcJXPPr (ORCPT ); Mon, 24 Oct 2016 11:15:47 -0400 Received: from vern.gendns.com ([206.190.152.46]:45273 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935236AbcJXPPo (ORCPT ); Mon, 24 Oct 2016 11:15:44 -0400 Subject: Re: [PATCH 2/5] ARM: davinci: Don't append git rev to local version To: Sekhar Nori , Kevin Hilman References: <1477075018-20176-1-git-send-email-david@lechnology.com> <1477075018-20176-3-git-send-email-david@lechnology.com> <20f3efba-4f79-3675-d2ce-09efe90fb692@ti.com> Cc: Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: Date: Mon, 24 Oct 2016 10:15:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20f3efba-4f79-3675-d2ce-09efe90fb692@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 25 On 10/24/2016 06:35 AM, Sekhar Nori wrote: > On Saturday 22 October 2016 12:06 AM, David Lechner wrote: >> In the davinci default configuration, don't append the git revision to >> the local kernel version by. This seems like the more desirable default >> value. > > Why? To the contrary I actually quite like the fact that the git commit > is appended to version string. Makes it easy for me to cross-check that > I am booting the right image. > >> >> Signed-off-by: David Lechner > > Thanks, > Sekhar > Each time you make a commit, you get a new version, which installs another copy of the kernel modules on the device. This will fill up the SD card if you are making many commits. Also, if someone wants to build the mainline kernel using the default configuration, it seems odd to have a git revision tacked on to the end even though you made no revisions.