Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965165AbcJXP5A (ORCPT ); Mon, 24 Oct 2016 11:57:00 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:52282 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939692AbcJXP47 (ORCPT ); Mon, 24 Oct 2016 11:56:59 -0400 Subject: Re: [PATCH] ARC: return -EFAULT on failed access_ok for arc_usr_cmpxchg syscall To: Colin King , Jiri Slaby , Andrew Morton , References: <20161024104714.10047-1-colin.king@canonical.com> CC: Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: <92d0dd5e-8aa8-3e55-193f-1fa440cb3ff3@synopsys.com> Date: Mon, 24 Oct 2016 08:56:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024104714.10047-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.43] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 30 On 10/24/2016 03:47 AM, Colin King wrote: > From: Colin Ian King > > arc_usr_cmpxchg currently returns an uninitialized value in ret > on a failed access_ok call. Instead, return -EFAULT. > > Signed-off-by: Colin Ian King > --- > arch/arc/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c > index a746008..9ae3e1c 100644 > --- a/arch/arc/kernel/process.c > +++ b/arch/arc/kernel/process.c > @@ -47,7 +47,7 @@ SYSCALL_DEFINE3(arc_usr_cmpxchg, int *, uaddr, int, expected, int, new) > int ret; > > if (!access_ok(VERIFY_WRITE, uaddr, sizeof(int))) > - return ret; > + return -EFAULT; > > preempt_disable(); Thx for spotting this. Since this is new code, not yet merged, do you mind if I squash it with orig patch. I can add a Reviewed-by a SOB as you prefer. Thx, -Vineet