Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757957AbcJXQg4 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 12:36:56 -0400
Received: from mail-yw0-f195.google.com ([209.85.161.195]:36170 "EHLO
        mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757933AbcJXQgx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 12:36:53 -0400
MIME-Version: 1.0
In-Reply-To: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
References: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Mon, 24 Oct 2016 12:36:52 -0400
Message-ID: <CADnq5_OwjmCJRjCj-VhE1jkL-e=Cy83Y=Hu1ftEFbX3TfKi4Cw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
        Dave Airlie <airlied@linux.ie>, Rex Zhu <Rex.Zhu@amd.com>,
        "Zhou, Jammy" <Jammy.Zhou@amd.com>,
        Eric Huang <JinHuiEric.Huang@amd.com>,
        Tom St Denis <tom.stdenis@amd.com>,
        "Edward O'Callaghan" <funfunctor@folklore1984.net>,
        Vitaly Prosyak <vitaly.prosyak@amd.com>,
        Eric Yang <eric.yang2@amd.com>, yanyang1 <Young.Yang@amd.com>,
        Huang Rui <ray.huang@amd.com>, Arnd Bergmann <arnd@arndb.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Flora Cui <Flora.Cui@amd.com>,
        =?UTF-8?Q?Nils_Wallm=C3=A9nius?= <nils.wallmenius@gmail.com>,
        "monk.liu" <Monk.Liu@amd.com>, Ken Wang <Qingqing.Wang@amd.com>,
        "Min, Frank" <Frank.Min@amd.com>, tang.qiang007@zte.com.cn,
        xie.baoyou@zte.com.cn, LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        han.fei@zte.com.cn
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1271
Lines: 19

On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: warning: no previous prototype for 'fiji_setup_pwr_virus' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smc.c:2052:5: warning: no previous prototype for 'fiji_program_mem_timing_parameters' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:175:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:1020:5: warning: no previous prototype for 'cz_tf_reset_acp_boot_level' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:92:26: warning: no previous prototype for 'cast_phw_smu7_power_state' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

This was already applied the last time you sent it out.  Sorry if I
didn't mention that previously.

Alex