Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757864AbcJXQqI (ORCPT ); Mon, 24 Oct 2016 12:46:08 -0400 Received: from mga03.intel.com ([134.134.136.65]:47871 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcJXQqG (ORCPT ); Mon, 24 Oct 2016 12:46:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,542,1473145200"; d="scan'208";a="23418898" Subject: Re: [RESEND PATCH v3 kernel 1/7] virtio-balloon: rework deflate to add page to a list To: Liang Li , mst@redhat.com References: <1477031080-12616-1-git-send-email-liang.z.li@intel.com> <1477031080-12616-2-git-send-email-liang.z.li@intel.com> Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, amit.shah@redhat.com From: Dave Hansen Message-ID: <580E3ACD.1080906@intel.com> Date: Mon, 24 Oct 2016 09:46:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1477031080-12616-2-git-send-email-liang.z.li@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 380 Lines: 7 On 10/20/2016 11:24 PM, Liang Li wrote: > Will allow faster notifications using a bitmap down the road. > balloon_pfn_to_page() can be removed because it's useless. This is a pretty terse description of what's going on here. Could you try to elaborate a bit? What *is* the current approach? Why does it not work going forward? What do you propose instead? Why is it better?