Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757998AbcJXQqe (ORCPT ); Mon, 24 Oct 2016 12:46:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33628 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753766AbcJXQq3 (ORCPT ); Mon, 24 Oct 2016 12:46:29 -0400 Date: Mon, 24 Oct 2016 18:46:26 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity Message-ID: <20161024164626.GD31643@krava> References: <20161024020246.14928-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161024020246.14928-1-namhyung@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 24 Oct 2016 16:46:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 36 On Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim wrote: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. ok, I added it to easily spot cpu columns I was interested in, but I think I can live with dotted line ;-) Acked-by: Jiri Olsa thanks, jirka > > Cc: Jiri Olsa > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index f5503ca22e1c..78006e991d91 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel, > cpu_color = COLOR_CPUS; > > if (cpu != this_cpu) > - color_fprintf(stdout, cpu_color, " "); > + color_fprintf(stdout, color, " "); > else > color_fprintf(stdout, cpu_color, "*"); > > -- > 2.10.0 >