Date: Mon, 24 Oct 2016 18:46:21 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 2/3] perf sched map: Always show task comm with -v
Message-ID: <20161024164621.GC31643@krava>
References: <20161024020246.14928-1-namhyung@kernel.org>
 <20161024020246.14928-2-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161024020246.14928-2-namhyung@kernel.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1195
Lines: 34

On Mon, Oct 24, 2016 at 11:02:44AM +0900, Namhyung Kim wrote:
> I'd like to see the name of tasks with perf sched map, but it only shows
> name of new tasks and then use short names after all.  This is not good
> for long running tasks since it's hard for users to track the short
> names.  This patch makes it show the names (except the idle task) when
> -v option is used.  Probably we may make it as default behavior.
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  tools/perf/builtin-sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 78006e991d91..97d6cbf486bb 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1493,7 +1493,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
>  		goto out;
>  
>  	color_fprintf(stdout, color, "  %12.6f secs ", (double)timestamp / NSEC_PER_SEC);
> -	if (new_shortname) {
> +	if (new_shortname || (verbose && sched_in->tid)) {
>  		const char *pid_color = color;
>  
>  		if (thread__has_color(sched_in))
> -- 
> 2.10.0
>