Subject: Re: [RFC 5/8] mm: Add new flag VM_CDM for coherent device memory
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <1477283517-2504-1-git-send-email-khandual@linux.vnet.ibm.com>
 <1477283517-2504-6-git-send-email-khandual@linux.vnet.ibm.com>
Cc: mhocko@suse.com, js1304@gmail.com, vbabka@suse.cz, mgorman@suse.de,
        minchan@kernel.org, akpm@linux-foundation.org,
        aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com
From: Dave Hansen <dave.hansen@intel.com>
Message-ID: <580E4704.1040104@intel.com>
Date: Mon, 24 Oct 2016 10:38:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1477283517-2504-6-git-send-email-khandual@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 846
Lines: 17

On 10/23/2016 09:31 PM, Anshuman Khandual wrote:
> VMAs containing coherent device memory should be marked with VM_CDM. These
> VMAs need to be identified in various core kernel paths and this new flag
> will help in this regard.

... and it's sticky?  So if a VMA *ever* has one of these funky pages in
it, it's stuck being VM_CDM forever?  Never to be merged with other
VMAs?  Never to see the light of autonuma ever again?

What if a 100TB VMA has one page of fancy pants device memory, and the
rest normal vanilla memory?  Do we really want to consider the whole
thing fancy?

This whole patch set is looking really hackish.  If you want things to
be isolated from the VM, them it should probably *actually* be isolated
from the VM.  As Jerome mentioned, ZONE_DEVICE is probably a better
thing to use here than to try what you're attempting.