Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756601AbcJXRxi (ORCPT ); Mon, 24 Oct 2016 13:53:38 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43276 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcJXRxe (ORCPT ); Mon, 24 Oct 2016 13:53:34 -0400 Date: Mon, 24 Oct 2016 18:53:20 +0100 From: Mark Brown To: ahaslam@baylibre.com Cc: gregkh@linuxfoundation.org, johan@kernel.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, david@lechnology.com, manjunath.goudar@linaro.org, abailon@baylibre.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20161024175320.GO17252@sirena.org.uk> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-10-ahaslam@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fpolVoprVozDR81Y" Content-Disposition: inline In-Reply-To: <20161024164634.4330-10-ahaslam@baylibre.com> X-Cookie: When the cup is full, carry it level. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH/RFT v2 09/17] regulator: fixed: Add over current event X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1730 Lines: 52 --fpolVoprVozDR81Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahaslam@baylibre.com wrote: > + if (ret) { > + pr_err("Failed to request irq: %d\n", ret); dev_err() > +++ b/include/linux/regulator/consumer.h > @@ -74,6 +74,10 @@ > * the most noisy and may not be able to handle fast load > * switching. > * > + * OVERCURRENT Regulator has detected an overcurrent condition, and > + * may be limiting the supply output. > + * > + * > * NOTE: Most regulators will only support a subset of these modes. Some > * will only just support NORMAL. > * > @@ -84,6 +88,7 @@ > #define REGULATOR_MODE_NORMAL 0x2 > #define REGULATOR_MODE_IDLE 0x4 > #define REGULATOR_MODE_STANDBY 0x8 > +#define REGULATOR_MODE_OVERCURRENT 0x10 This is adding a new core feature with a new mode and should have been split out of the driver specific change with a spearate changelog. Why does it make sense to report this as a mode, we don't report other error conditions as modes but instead use REGULATOR_STATUS_ with the get_status() operation? --fpolVoprVozDR81Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYDkqOAAoJECTWi3JdVIfQrm4H/j8ppy9ICV8PbApuQVlmdQVy O0yrpQZ+MEqJb+pQqxnlwSlSWeWFysUIOPHdi80OIJ/9EfJfjavmSA+EyblLWJfh 7gQ/+fy7KIaWACGORlLq8q1GVz4TvEVbLIC9oDpBIhzRp/Qs9mpK8NFqejFlLOoZ V5UIVGLngb+DezWW2W6CT57/arJmyi20C9Mj5Y7URfzpeqT7WMbPBVwP0D500iAk BysjGVZUzaFzNAKXypCXlnknJGespx67dvxAsWh4wp01n5BsoZvdCFv81xERrm7t KjXybzY3ZdsrBOja1MLNGUqWBPYpq3zcVowi7QPZ0XmrVjUyMFb78CQatdUtw/k= =fuoz -----END PGP SIGNATURE----- --fpolVoprVozDR81Y--