Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938975AbcJXSUR (ORCPT ); Mon, 24 Oct 2016 14:20:17 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:39141 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751427AbcJXSUJ (ORCPT ); Mon, 24 Oct 2016 14:20:09 -0400 Date: Mon, 24 Oct 2016 13:20:00 -0500 From: Reza Arbab To: Michael Ellerman , Alistair Popple Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Andrew Morton , Stewart Smith , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Chen , linux-mm@kvack.org, "Aneesh Kumar K.V" , Bharata B Rao , Nathan Fontenot Subject: Re: [PATCH v4 2/5] drivers/of: do not add memory for unavailable nodes References: <1475778995-1420-1-git-send-email-arbab@linux.vnet.ibm.com> <1475778995-1420-3-git-send-email-arbab@linux.vnet.ibm.com> <2344394.NlaWgtFOqB@new-mexico> <87vawixcxn.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87vawixcxn.fsf@concordia.ellerman.id.au> Organization: IBM Linux Technology Center User-Agent: Mutt/1.6.2-neo (2016-08-21) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102418-0028-0000-0000-000005E0107A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005971; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000187; SDB=6.00772167; UDB=6.00370598; IPR=6.00548984; BA=6.00004826; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013091; XFM=3.00000011; UTC=2016-10-24 18:20:06 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102418-0029-0000-0000-000030481EEC Message-Id: <20161024182000.5g2f3w3x3oqrohqs@arbab-laptop.austin.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-24_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610240320 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 748 Lines: 20 On Mon, Oct 24, 2016 at 09:24:04PM +1100, Michael Ellerman wrote: >The code already looks for "linux,usable-memory" in preference to >"reg". Can you use that instead? Yes, we could set the size of "linux,usable-memory" to zero instead of setting status to "disabled". I'll send a v5 of this set which drops 1/5 and 2/5. That would be the only difference here. >That would have the advantage that existing kernels already understand >it. > >Another problem with using "status" is we could have device trees out >there that have status = disabled and we don't know about it, and by >changing the kernel to use that property we break people's systems. >Though for memory nodes my guess is that's not true, but you never know ... -- Reza Arbab