Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965260AbcJXSl0 convert rfc822-to-8bit (ORCPT ); Mon, 24 Oct 2016 14:41:26 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:59639 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935263AbcJXSlX (ORCPT ); Mon, 24 Oct 2016 14:41:23 -0400 From: Alexey Brodkin To: Daniel Vetter CC: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Eugeniy Paltsev" , "dri-devel@lists.freedesktop.org" , "architt@codeaurora.org" , David Airlie , Ramiro Oliveira Subject: RE: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Thread-Topic: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Thread-Index: AQHSKdzlNgYQRNBwDkuafqtoQBvjQKCvXP+AgAAFE4CACJGjgA== Date: Mon, 24 Oct 2016 18:33:51 +0000 Message-ID: <4881796E12491D4BB15146FE0209CE646784BA6F@DE02WEMBXB.internal.synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> <1476869529.3348.27.camel@synopsys.com> In-Reply-To: <1476869529.3348.27.camel@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.2.150] Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1919 Lines: 45 Hi Daniel, > -----Original Message----- > From: linux-snps-arc [mailto:linux-snps-arc-bounces@lists.infradead.org] On Behalf Of Alexey Brodkin > Sent: 19 ??????? 2016 ?. 12:33 > To: dri-devel@lists.freedesktop.org; architt@codeaurora.org; Eugeniy.Paltsev@synopsys.com > Cc: linux-snps-arc@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge > > Hi Archit, all, > > On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote: > > > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > > > ARC PGU driver starts crashing on initialization after > > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > > So, when we call "encoder_init" function from this structure driver > > > crashes. > > [snip] > > > Looks good now. > > > > Reviewed-by: Archit Taneja > > And IMHO it would be really good to get this one back-ported to 4.8 > because it really fixes kernel crash if ARC PGU driver is used. > > It might be a bit of a problem because patch itself a little-bit larger > than formal requirement for stable backports but let's see if it gets accepted. Could you please pick this one up? I may alternatively send a pull-request to David but not sure if 1 patch worth it. Also if that's not really too late it would be good to get this one in 4.9 since the patch In question fixes a real driver crash on its instantiation. Actually driver crash happens since 4.8 but I failed to notice it earlier and given amount of changes I think there's barely a chance for it it to be accepted in stable branches... which in its turn makes at least 4.9 very desirable. -Alexey