Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934108AbcJXTDd (ORCPT ); Mon, 24 Oct 2016 15:03:33 -0400 Received: from up.free-electrons.com ([163.172.77.33]:52861 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936512AbcJXTDZ (ORCPT ); Mon, 24 Oct 2016 15:03:25 -0400 Date: Mon, 24 Oct 2016 16:05:17 +0200 From: Maxime Ripard To: LABBE Corentin Cc: Jean-Francois Moine , robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, devicetree@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dt: sun8i-h3: Add sunxi-sid to dts for sun8i-h3 Message-ID: <20161024140517.kv6wkzifgibyv7sl@lukather> References: <1475660904-7959-1-git-send-email-clabbe.montjoie@gmail.com> <20161005122130.8cc229ff5d4990149956b49c@free.fr> <20161019074016.GA31440@Red> <20161020203654.2erph2mr73yzksla@lukather> <20161023082631.GA28485@Red> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dhjasci7bsrokpr2" Content-Disposition: inline In-Reply-To: <20161023082631.GA28485@Red> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3688 Lines: 97 --dhjasci7bsrokpr2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 23, 2016 at 10:26:31AM +0200, LABBE Corentin wrote: > On Thu, Oct 20, 2016 at 10:36:54PM +0200, Maxime Ripard wrote: > > On Wed, Oct 19, 2016 at 09:40:16AM +0200, LABBE Corentin wrote: > > > On Wed, Oct 05, 2016 at 12:21:30PM +0200, Jean-Francois Moine wrote: > > > > On Wed, 5 Oct 2016 11:48:24 +0200 > > > > Corentin Labbe wrote: > > > >=20 > > > > > This patch add support for the sunxi-sid driver to the device tre= e for sun8i-h3. > > > > >=20 > > > > > Signed-off-by: Corentin Labbe > > > > > --- > > > > > arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++ > > > > > 1 file changed, 5 insertions(+) > > > > >=20 > > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/= sun8i-h3.dtsi > > > > > index 9f58bb4..abfd29c 100644 > > > > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > > > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > > > > @@ -211,6 +211,11 @@ > > > > > #size-cells =3D <0>; > > > > > }; > > > > > =20 > > > > > + sid: eeprom@01c14200 { > > > > > + compatible =3D "allwinner,sun7i-a20-sid"; > > > > > + reg =3D <0x01c14200 0x200>; > > > >=20 > > > > The datasheet says 1Kb starting at 0x01c14000. > > > > Is there any reason to reduce the area and to shift the offset? > > > >=20 > > >=20 > > > According to http://linux-sunxi.org/SID_Register_Guide "For > > > Allwinner A83T and H3 the SID address space starts at 0x01c14000, > > > and the e-fuses are at offset 0x200". > > > > > > So I use this offset, since the sunxi_sid driver need the base > > > address of e-fuses. > > >=20 > > > The easiest solution is to use 0x01c14200 since the other part of > > > sid is not used and not known (A83T/H3 user manual doesnt give any > > > information on all sid space, worse for A64 which reference SID only > > > in memory map). > > >=20 > > > So probably for H3/A64/A83T, there will never any usage of the rest > > > of the SID address space. > >=20 > > And since we can't know that, and we have to maintain the DT ABI, > > using the whole address map and an offset, with a new compatible, is > > definetely the safest thing to do. > >=20 >=20 > I have two way of doing it, which one do you prefer ? >=20 > - Adding two optionnal properties: efuses-offset and efuses-size defaulti= ng to 0 and resourcesize. > - Adding a subnode called efuses with its own reg=3D<> >=20 > The first one is easy and didnt need any work on previous DT entries. I'd prefer to have a compatible, and the size and/or offset of the efuses associated to it. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --dhjasci7bsrokpr2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYDhUdAAoJEBx+YmzsjxAgKL4P/1Eamgd1IEgNM3hJYl5RuosR P1Aduq8oMTb1vogWgsXtwIreCGbWQd97KuQ7Yx/qEyxnyO4ibLMcwg5VfQ2p0z2b ftRjcpX59FGAZuxSl6xN/iAXlEPVul5mMjuir6uhwKbhmvsxeCOTnd9+Ty0dc0U2 KreodW6nFw+2IbSmn2AbFf2tNuG0exBo5pzJUSjfjULZlnYq3+LfA8mUnpZmoZOA 57z9R7Xh30RDcktSLyhxh1F/Z3y8n9Fgn5/oVFa/SKOq2lYt23/JjewK5h9U+9D7 LaaNRaSDRjM8fcHsQ52W6rPo4dpTTTmj8nE9bXguW+yXf+d/M/Lm0KBDypLQ7Krx AgJORfrb3Mw2tkPOsHch8/mrno0Jc5tkr+r7YJ+IHk/wZvk/fLKzPVHx+M52weJx gX10c21uWp1SNyU0F8eIs8rqE8cmzH1OSnH958VhtVfTHJTvyp2FG/3Y3pQmzilb GCEafuNEXAllrfp76q0WlGx9lWRdguexm2+S/i8C4UpvpGmn8apu3QB9GDBEHeXG U1tBOAAg5+c8rd6bVgEeNuyhiinT+lT1/hvut+hGKV2Nnazx8Y27qVROeTm53gU/ WZsDThoELw6IFtkdx4PSZjxo/9ul8OoYzdz3E737q/YHmAVsjL5MlfsWRuBQj23+ igtEeUXzVzC8vaMlnl/M =VsWk -----END PGP SIGNATURE----- --dhjasci7bsrokpr2--