Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965254AbcJXTKb (ORCPT ); Mon, 24 Oct 2016 15:10:31 -0400 Received: from mail-yb0-f176.google.com ([209.85.213.176]:37817 "EHLO mail-yb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938727AbcJXTK1 (ORCPT ); Mon, 24 Oct 2016 15:10:27 -0400 MIME-Version: 1.0 In-Reply-To: <20161024164218.GT3102@twins.programming.kicks-ass.net> References: <20161024160814.3126-1-roman.penyaev@profitbricks.com> <20161024164218.GT3102@twins.programming.kicks-ass.net> From: Roman Penyaev Date: Mon, 24 Oct 2016 21:10:06 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc To: Peter Zijlstra Cc: Andy Lutomirski , Oleg Nesterov , Thomas Gleixner , Ingo Molnar , Tejun Heo , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 627 Lines: 21 On Mon, Oct 24, 2016 at 6:42 PM, Peter Zijlstra wrote: > On Mon, Oct 24, 2016 at 06:08:13PM +0200, Roman Pen wrote: >> This patch avoids allocation of kthread structure on a stack, and simply >> uses kmalloc. Allocation on a stack became a huge problem (with memory >> corruption and all other not nice consequences) after the commit 2deb4be28 > > 2deb4be28077 ("x86/dumpstack: When OOPSing, rewind the stack before do_exit()") > > Is the normal quoting style. > > .gitconfig: > > [core] > abbrev = 12 > [alias] > one = show -s --pretty='format:%h (\"%s\")' Nice tip. Thanks. -- Roman