Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941500AbcJXTSj (ORCPT ); Mon, 24 Oct 2016 15:18:39 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:38428 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938727AbcJXTSe (ORCPT ); Mon, 24 Oct 2016 15:18:34 -0400 Subject: Re: [PATCH] nbd: fix incorrect unlock of nbd->sock_lock in sock_shutdown To: "John W. Linville" , References: <1477336405-28442-1-git-send-email-linville@tuxdriver.com> CC: , Josef Bacik , "Markus Pargmann" From: Jens Axboe Message-ID: <3492bfec-3204-1f5f-075b-d5e619af44f4@fb.com> Date: Mon, 24 Oct 2016 13:17:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477336405-28442-1-git-send-email-linville@tuxdriver.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR18CA0035.namprd18.prod.outlook.com (10.164.243.45) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 8f053318-45f6-4c75-7531-08d3fc4279e3 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:Or9RX8G2MsIeLqGdJLF8pOjjNrNDnfZg0oNyvsE9fXSHiwpKG3ewzwigQKCYKVZgyL+inS1qgE/maUsPizLZoiwN4D2Q991EZHgJcfB/N+oOSDUlPgP8CBw8k0DnY6aooVIq9+frBekuEn+VwQD0QaFmN1XqRCYTEXWfJa6s151ohbK0JnQqRoG9jubHiMNoSMhx5zG/Wzz7I9ztVYTtQg==;3:PNCzRlKeoPuv1eHeo8hw8x/UJbHBoDGaoDhvtcjr8sCdZskTSwD8ts/vTegeMU7WkOvB0mjvr+foBNkcUVUWdBbDPw0ieBfNXbA0Zt4JWF+OEM+mgyr+V6fH8g5JoiD8VLKTmoxWnXlHCRCdMZFuMg==;25:Ikwfbx6fTvWEgV7ONj5NFQe1DgM1wmdKNsQaT0Mmee42G0k/FzYSZnbKKJ/Kooqsz974vOnEa5Rgmj7me969Fhemi6OzFk+wzUgiPcJXjmpeyoHs6hSBEcfUnjn3wW7XpPRl4hcRV6uKDJEOSKjSc4u90ABkdAahzAaYfx0nDNjtREk5/4ds5ikrWjM+aIpVCL8cFiOyYzUz/84twWp+3mFJ2RtStvicXjex6RSUTpXOVIKhnSjzyqjVyx79uaAQSwr9OXooo2onkuvxCLg5dduwktPsQgKN77hnZGQ/5YXn15yGzUrnPehKLSg9tQPyOy0ttiRuMI1JFcNq4whK0XodJmRsp9YfWMKZ/kjCbarej4GTD2NS8f9L2xiQuEIHw2qSPEBMICavN2+3HC8Ipq4AQiCze+p4UNW5vsUSTIFHrBCVwZ4lVg1U5YGOdYIe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:iVbbuiCvTVd38CVulROhIf7S9PTGj9MDbliPJO5XyDHjMR5Eon9oJ7xIXCG9Xb5+rGaFAEfmXHaUAhPjSAQJHmA/REM7FzcM9pq3Mu+bhyZcmng3N2Np19EYIBtVJOuXLxqVlRGjrhbCCL6kkc66tugNddVHuxdqFwfViR7E5XLuBTgSHKxyhZDWO+6u5WR3pznAb5kJOIPdHC+y3yWNTMiCe1i1PpABH3B40iR3FK45CI46rss+ODXQPj+IIV4l9qtDyacocovt0PR/QqD33A==;20:sKvBSt4rRDocvR6KZXunrXmYqRo2VjtLWHb0Yh9ig3zidcoz16tx3mZSCHnQwMd9SVBXFKrmqVdBwEtxjUj5BpKf+SSZMlwQfwnpNCpMQvK7CemuIypZ9h88EDrKoNUvi+IULlICWHKhmRe6dPk9EDVXY/S2Xb+2gw7bSrlgVCc=;4:WIoadnLnokVv6d9eSQH3TG7tEscvEof5So7OE8hBmn1+jKTxErTT12gISqIPgMaNfhwU9awQoCDT9UrGt9K8yX2clReSr7DOfKkealU9vDAm4qfotPxpv62qIpwUBMV3PLUSajizDWMtO1RyADmolaYn2eztTxnBKuYYPtdUK318+LiSyw/CF5fpDrEh/choNsr4Y4b11+xhVru00ahFKs73CnvbjsWL0xNNRESHX6h6hF0JLSEMm1UgfdfISmHOVX9ficNl1h7EKSRaqoan2uCKNvkQIRvGFii+uywkTYEUf4nwoZUKSIQeEQNIjyKrkt7YL2a7b92hmaQ50zeSYeG5rcTCgUgrGXMWVQUFT2F1b3fgumcUOTH8ih272EBXSyR55wKpcCGLl5cpllwkVQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 0105DAA385 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(24454002)(377454003)(189002)(3846002)(586003)(6116002)(230700001)(4326007)(305945005)(6666003)(105586002)(31686004)(68736007)(42186005)(2950100002)(189998001)(77096005)(7736002)(65806001)(47776003)(83506001)(65956001)(66066001)(7846002)(2906002)(117156001)(50986999)(81156014)(4001350100001)(8676002)(92566002)(97736004)(54356999)(76176999)(86362001)(33646002)(81166006)(36756003)(65826007)(5660300001)(101416001)(23746002)(106356001)(5001770100001)(64126003)(31696002)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:aOh1kic2nOJw6s9BGOHqgAB4FATOubloMGwKI?= =?Windows-1252?Q?53mfj8AjEgAN+o8XXoUtkdz+hYQcCnR5F+Ygk8fAK9MmnZ8FLe2PypKc?= =?Windows-1252?Q?tcqSYi9osnO4ZFrOGM5BPxA9YpWojRp1ElX5o9zQnDVJOOZ5CCDRIeX7?= =?Windows-1252?Q?BhPyH5m1+a9n0iQZcGlMepqpVA2HRyhaDAyHLvoiKUObq2h3WfH+J9xH?= =?Windows-1252?Q?nDS+qUKBbRnUdrT+U343tODLd/BvKkzp7tDpsjtk5Owwy5vAOrpb87jE?= =?Windows-1252?Q?iFiSjAHnjMUBzLU8+y8hWJU2dBjC9/kI5WOndr4YC0gJhQ+XFeg7D1El?= =?Windows-1252?Q?hnZA4ah+8Paaa6V8VYHf3YF2YkkMUreliqad/r33/K/ARoMhLku+UszU?= =?Windows-1252?Q?Q0zkY56izvEhJmTQ1BWea3ag+dqtg7R6NXyo61ZyuAPdbW9phbAocD4B?= =?Windows-1252?Q?+hFs3xN4+UluDrQoqijUw2si0mgYBuG4pYOjwAIQSh649B9WGKjikNGM?= =?Windows-1252?Q?GstVlIZ2fM8JcWHt58Y+SfMqklz0Owtkk8TgYVOmQ91/aBcReuYsDaAV?= =?Windows-1252?Q?XdaaOz1SmkNUEPL6+Rmp6rKy5xfqDD/cNLURP/do068xyREPSLetOtd1?= =?Windows-1252?Q?UQLjG8pQDqA8kmttAYN2+kKRRSqD+0AuILagdJNYsUFKuz74iJ6JNWN3?= =?Windows-1252?Q?pHP2/DriIexWN/o0I7g4ire1jjm79DNbZcC78ZesA4jc4GyZxcXkWcAZ?= =?Windows-1252?Q?iECD1mOA9WKGLuc9DyPLmwCtPfPS7m2todDCGC0m0RtWX8pBW/52jZPX?= =?Windows-1252?Q?2mB1dbDvi7RNVvufbRAcj0gI4hBe8U5lzaR3jw808vYTMQDn2uN5P3gn?= =?Windows-1252?Q?HhxYK77q8Js75qVn+f30Eb0SwJxkIgk51+5O7kvIAILGyB7UHWsU3G0e?= =?Windows-1252?Q?AvK1yfRnm0vIH0QDaTQuezKEBQovy85aP3Xnnlig3McN3d3jbai4FtpJ?= =?Windows-1252?Q?jYyQIXth2qLLDMiwco3DFBDM4MoILYweBasazQv7Wg6TX8EXuBCFNOZU?= =?Windows-1252?Q?ndOCNqWSUwWK6tYNQ1GnzZyzOCrVvuvBiB9VCLnj822Xu1UxygO+d+mN?= =?Windows-1252?Q?RrEeDtFyFYxzXNUV/pnQdx+TngbX5e4cscbO5pTAEY62bUBKWOUPA+xr?= =?Windows-1252?Q?GQgPXBlJTxfvw1dwHztMKt9d/PGXDvKlUV7xx4ofEkiMmjVGDylF3GZy?= =?Windows-1252?Q?QVnP/Jt6+lSp8S7+qC2IfEomNZqUKDGiBOvTzUFyFmXDWctrbSaxaRNi?= =?Windows-1252?Q?YDW2YIsldEt7jjQyQTsekabeChCZ1TvYGQZL3+J9xsCHvEDGRi8HC1Fw?= =?Windows-1252?Q?hRXiP4HIuZ/v0J4KbimOKwBWeoY7N6oFw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:iryZmVBrMXOSnM2mP45hrdbf5yqjv7761kYzzSeXbGfzdIU8CPJMzhyrn9sOWnVEA4T3tixkUz3f6K1OSUtCb4Usn0ECLS4/Itpcms79x/EvO+XqOpfxI79YJGf8E2OzFQ+/dXidRIS+iji/pvQcfT/03V4ji6JFL6uAOcGAemHLmrJ8YraFLmj99XBLOUYGHEn1lhIC9qSi2L8yJK5tfgFs0XkNIbTd0YC4AfX6MuID5yUN76X2n6kEb17gN8jETTRpAlZbV7XuFSDgBneogCzjj5qbPdORD0O+uK3cSg5Fv2mnWiy3drfGpwdYqX+i;5:+Ic5+pncRFQx//wz1WEpaDd2Z0GQXJ+IB4KHj9kWfZmOIY4uZhqcXgVXm/oMttaaJDpMDx+QCcrYeEz3rwBr3I2BC2JJXlHS8FYGKDZ81FtvzNmxcRVj0Z1NNcVY/4EVXjeiDI52FGR+tXO/I98tsw==;24:5pAPWGeCXQVGZOl5IG15OwGQr5zBBlv8ictEV5lmPcQKrU56koFfW0QprbKsZcgfBDFzZAB0i4zE34LCUZc+nc37pQVsZ1FJ/d+7/BGCS4E=;7:/KRR7RHP0R/Etc/gSIQR9uKAVfUwKE0764qLke0/uwOthsKK2P/9WLZcnHLdYU1r9chNygKShh7oME+a0QizQhp4/9KCzDJYJUnP6Ue8HxatXJ1ujrsi0M3IPearfi9JZ8ty4hpi17V4FqxdDsPHLO8eA4PommqfB6XSBZf2ZbdGyIUd4nGo07hiPWqofHiswrXFaXqM8g4lnKxEOlIDCL9d/lhicAZnOWFqTqsbzA+Lc/0dO6UT6G/IJIwZsK/f8oPldB/BHoV5EIRkuA2Zw/2ANu7qs/6uuGnnnWC2KpkDL3BPsMO1ZhTkeyfLgeN8FxTpb6B+3oEwwjno/VhCz+DbDVQon8cN1g3f4duXsck= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:uzT3tHXkcIcfNYCjzrSd1QbAMvzYiPTMiMFbvzUFLc41kNtUq/Or3PG6xCsT09yEknkZaVOxlv4tWl9VEOwmDvqV5TINTmPeJNYpZdrn3VrLj9jB8MhnudwRYeGSoZR2llC6RojDVyOiGT9g8SDLuPsakts6yxtr7QCHnxwpG08= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2016 19:18:02.8309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-24_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 306 Lines: 10 On 10/24/2016 01:13 PM, John W. Linville wrote: > Commit 0eadf37afc250 ("nbd: allow block mq to deal with timeouts") > changed normal usage of nbd->sock_lock to use spin_lock/spin_unlock > rather than the *_irq variants, but it missed this unlock in an > error path. Thanks John, applied. -- Jens Axboe