Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938991AbcJXTiR (ORCPT ); Mon, 24 Oct 2016 15:38:17 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:55294 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935260AbcJXTiP (ORCPT ); Mon, 24 Oct 2016 15:38:15 -0400 Date: Mon, 24 Oct 2016 21:38:11 +0200 From: Markus Trippelsdorf To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] perf hist browser: Fix hierarchy column counts Message-ID: <20161024193811.GD302@x4> References: <20161024162110.17918-1-namhyung@kernel.org> <20161024170040.GC302@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161024170040.GC302@x4> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 21 On 2016.10.24 at 19:00 +0200, Markus Trippelsdorf wrote: > On 2016.10.25 at 01:21 +0900, Namhyung Kim wrote: > > The perf report/top on TUI supports horizontal scrolling using LEFT and > > RIGHT keys. But it calculate the number of columns incorrectly when > > hierarchy mode is enabled so that keep pressing RIGHT key can make the > > output disappeared. In the hierarchy mode, all sort keys are collapsed > > into a single column, so it needs to be applied when calculating column > > numbers. > > Thanks, this is much better now. > > But it doesn't scroll wide enough. In "perf top" when I press the RIGHT > key the symbols are shown on the hard left side. In "perf top --hierarchy", > when I press the RIGHT key, there are 5 empty spaces on the left hand > side that should be deleted. It might be a good idea to keep the + and - signs on the left hand side when scrolling horizontally like "perf report -g" does. -- Markus