Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941358AbcJXTtg (ORCPT ); Mon, 24 Oct 2016 15:49:36 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:51246 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941144AbcJXTtc (ORCPT ); Mon, 24 Oct 2016 15:49:32 -0400 From: Arnd Bergmann To: Alex Deucher Cc: Baoyou Xie , "Deucher, Alexander" , Dave Airlie , Rex Zhu , "Zhou, Jammy" , Eric Huang , Tom St Denis , "Edward O'Callaghan" , Vitaly Prosyak , Eric Yang , yanyang1 , Huang Rui , Dan Carpenter , Flora Cui , Nils =?ISO-8859-1?Q?Wallm=E9nius?= , "monk.liu" , Ken Wang , "Min, Frank" , tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn, LKML , Maling list - DRI developers , han.fei@zte.com.cn Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible Date: Mon, 24 Oct 2016 21:49:12 +0200 Message-ID: <3749845.re3cZTKYeA@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:SHp2YfgUhR8c1COSVnwbCF0m6I/BBFm4ENi6ZDy/zN34bYeSDuN pxYXHuEYX5TXA8rmD7ItLO/LD4XU7wUBxbTiRaJMw0UqdKSKZTZsYrvim4uLjA556F9ZJl9 DvRv3xYpCKNfx6dmcSwYVQAFC4ejvOR3XzS8e1TVkbd2IvpHguebROGwq5RSKJdmQZFuJDu vRYfw6lvjRW6Vm2K/ED5w== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zrd+CN4X9Oc=:9CiStmZaaNK9Ae11WT4nb1 42EHjW1J3Muucn/shTjqGfUdjlfVx23ByWeq6Qu8EjEAE61KCIS8AiNTx9Xy35TvBxprqNVPK +7jYUwu6szu2L9k1uLVx6HOrjC+SarOrFdKKE4LGqR+PhDdbyL+jy2Y3meV+5elmPj5V42rkx 8gUOsazXtU28xT87MXkY5a7pnXFwtn8gLV2bDE4sqz8a6I0RkeNIinBV0XYwtUNyzeD8f/aIk cd87bVweKcHKrFMTE/UI+1DLnA7HTOQZAGMNFUPIjS6m80eymj7Q5JpYxRakpkZ92i/emRn5E Vs84H5QHlJr4L70gpkQY3Y2RP1BCI6+0obcabG0SyOl6mF4UXhn/LNaUrhCGU5gPf6qzouJb5 koOD2nm/RwdhW22Im6U1+xPsaPiqtr4kcUHeiEPcu9zdF6UGbyZWkglV0w6r/cfJVL9LM2ab3 Q5E6wCEaKbyAEI2dMECeCreHsBJd6pXpuHcZEWoUs0Yjrp1iWyz2tTvaBYfCnmPeve6gjK2TA KqsPxGj4UStgzt7Bf1tU5GaQOfrSjO7oVCI81bu4b8OKV2ZLcxOkaltAAH+lB/eB13mj66FSM DHB2FJDZYKLqgIMtzzD9tAKCCWOna3m+ZZ7+XMPpw/2hyapPNmNZOcM+D3SesrdRUgnTul7Sd iQOqGfUYdA1SEKoUI0p/Ctz7mXoBXgr2bakfL4IMbxFNZKFgBVKDrP5pv39Urz6DQovbAFVg0 0rreED/8JeaXt5/B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2112 Lines: 34 On Monday, October 24, 2016 12:36:52 PM CEST Alex Deucher wrote: > On Sat, Oct 22, 2016 at 4:56 AM, Baoyou Xie wrote: > > We get a few warnings when building kernel with W=1: > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:162:5: warning: no previous prototype for 'fiji_setup_pwr_virus' [-Wmissing-prototypes] > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smc.c:2052:5: warning: no previous prototype for 'fiji_program_mem_timing_parameters' [-Wmissing-prototypes] > > drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/polaris10_smumgr.c:175:5: warning: no previous prototype for 'polaris10_avfs_event_mgr' [-Wmissing-prototypes] > > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/cz_hwmgr.c:1020:5: warning: no previous prototype for 'cz_tf_reset_acp_boot_level' [-Wmissing-prototypes] > > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:92:26: warning: no previous prototype for 'cast_phw_smu7_power_state' [-Wmissing-prototypes] > > .... > > > > In fact, these functions are only used in the file in which they are > > declared and don't need a declaration, but can be made static. > > So this patch marks these functions with 'static'. > > > > Signed-off-by: Baoyou Xie > > This was already applied the last time you sent it out. Sorry if I > didn't mention that previously. For some reason the patch hasn't made it into linux-next, so I can see why Baoyou was getting confused here. Can you clarify what the timeline is for the AMD DRM driver patches from between they get applied to the AMD tree to when they make it into linux-next? I've occasionally had a hard time with DRM (and a few other subsystems) with bugfix patches trying to find out whether they got lost or whether they just haven't made it into -next but are in some other tree. Baoyou, when you resend a patch, please try to list explicitly why you are resending it, when it was last sent, and what kind of reply you got (integrating any Ack, listing what changes you did, and if there are no other changes, why you think you have to resend it). Arnd