Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941364AbcJXT4B (ORCPT ); Mon, 24 Oct 2016 15:56:01 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34537 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938739AbcJXTz7 (ORCPT ); Mon, 24 Oct 2016 15:55:59 -0400 MIME-Version: 1.0 In-Reply-To: <20161024195151.GA5989@amd> References: <1474083775-30185-1-git-send-email-matt@ranostay.consulting> <1474083775-30185-2-git-send-email-matt@ranostay.consulting> <20161007184910.GF19976@amd> <20161024195151.GA5989@amd> From: Matt Ranostay Date: Mon, 24 Oct 2016 12:55:17 -0700 Message-ID: Subject: Re: [PATCH 1/2] power: bq27xxx_battery: add configurable poll_interval by sysfs To: Pavel Machek Cc: "Andrew F . Davis" , Sebastian Reichel , linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" , Matt Ranostay Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 38 On Mon, Oct 24, 2016 at 12:51 PM, Pavel Machek wrote: > On Sun 2016-10-23 20:08:22, Matt Ranostay wrote: >> On Fri, Oct 7, 2016 at 11:49 AM, Pavel Machek wrote: >> > On Fri 2016-09-16 20:42:54, Matt Ranostay wrote: >> >> Allow the poll_interval to be runtime configurable via an sysfs entry. >> >> This is needed for udev control of the poll interval. >> >> >> >> Signed-off-by: Matt Ranostay >> > >> > working mail address would be nice here. >> > >> > sysfs files should be documented. >> > >> >> Ok can do in next revision >> >> > Also... what is it good for? >> > >> > Do you have a device that needs non-standard interval? >> >> Basically we need to have the ability to dynamically change the >> intervals. So closer to a battery drain we need to up the reporting >> intervals. > > Umm, there seems to be mechanism there to change that already...? > Ah right. Commenting on the wrong patchset oops :). > static const struct kernel_param_ops param_ops_poll_interval = { > .get = param_get_uint, > .set = poll_interval_param_set, > }; > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html