Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941173AbcJXU1c (ORCPT ); Mon, 24 Oct 2016 16:27:32 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:34509 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbcJXU1b (ORCPT ); Mon, 24 Oct 2016 16:27:31 -0400 Date: Mon, 24 Oct 2016 16:27:28 -0400 From: Tejun Heo To: Roman Pen Cc: Andy Lutomirski , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] workqueue: ignore dead tasks in a workqueue sleep hook Message-ID: <20161024202728.GC32050@htj.duckdns.org> References: <20161024160814.3126-1-roman.penyaev@profitbricks.com> <20161024160814.3126-2-roman.penyaev@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161024160814.3126-2-roman.penyaev@profitbricks.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 505 Lines: 15 Hello, On Mon, Oct 24, 2016 at 06:08:14PM +0200, Roman Pen wrote: > If panic_on_oops is not set and oops happens inside workqueue kthread, > kernel kills this kthread. Current patch fixes recursive GPF which > happens when wq_worker_sleeping() function unconditionally accesses > the NULL kthread->vfork_done ptr trhu kthread_data() -> to_kthread(). Other than the pointed out style issues, looks good to me. If you send an updated version, I'll route it through wq/for-4.9-fixes. Thanks. -- tejun